Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Oct 9, 2025

Fix: Disable IPFS service from installation and delete from the current ones, to avoid getting Out-Of-Memory on the CRNs.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Removed IFPS installation and clean up the existing service if it exist on the system.

How to test

Install on an new CRN and check that IPFS service is not installed.

@nesitor nesitor requested a review from odesenfans October 9, 2025 08:55
@nesitor nesitor self-assigned this Oct 9, 2025
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged, there's just a typo in a comment

…nt ones, to avoid getting Out-Of-Memory on the CRNs.
@nesitor nesitor force-pushed the andres-fix-disable_unused_ipfs_service branch from e8c5c6e to a74961d Compare October 9, 2025 13:45
@nesitor nesitor marked this pull request as ready for review October 9, 2025 13:45
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.84%. Comparing base (c79a8cc) to head (a74961d).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   64.84%   64.84%   -0.01%     
==========================================
  Files          87       88       +1     
  Lines        8095     8160      +65     
  Branches      723      734      +11     
==========================================
+ Hits         5249     5291      +42     
- Misses       2620     2640      +20     
- Partials      226      229       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nesitor nesitor merged commit fde619c into main Oct 9, 2025
35 of 37 checks passed
@nesitor nesitor deleted the andres-fix-disable_unused_ipfs_service branch October 9, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants