[Fix] Set default item type early #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the previous fix. Some messages end up with check_message set to False, bypassing the validation in `incoming`. We now set the default value of `item_type` as the first thing in the function. Note that this is a temporary fix that will disappear as soon as we use Pydantic models everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the previous fix. Some messages end up with check_message
set to False, bypassing the validation in
incoming. We nowset the default value of
item_typeas the first thing inthe function.
Note that this is a temporary fix that will disappear as soon
as we use Pydantic models everywhere.