Fix: general 500 error on posts endpoint #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the "/api/v0/posts.json" endpoint returns a 500 error because of an invalid parameter being used in a function (an attempt to remove the MongoDB object ID from the endpoint). Solution: remove the object ID directly in the aggregate query. Added a simple test to verify that the endpoint is at least working a little bit.
hoh
reviewed
Oct 6, 2022
| def get_messages_by_predicate( | ||
| messages: Iterable[Dict], predicate: Callable[[Dict], bool] | ||
| ) -> List[Dict]: | ||
| return [msg for msg in messages if predicate(msg)] |
Member
There was a problem hiding this comment.
Is this function really useful ?
It introduces the uncommon term predicate and only contains a trivial one line of code.
Collaborator
Author
There was a problem hiding this comment.
I use it a ton in another PR, just thought I'd introduce it here so that it's already in. I can rename 'predicate' to 'cond', that works as well.
odesenfans
added a commit
that referenced
this pull request
Oct 17, 2022
Problem: the "/api/v0/posts.json" endpoint returns a 500 error because of an invalid parameter being used in a function (an attempt to remove the MongoDB object ID from the endpoint). Solution: remove the object ID directly in the aggregate query. Added a simple test to verify that the endpoint is at least working a little bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the "/api/v0/posts.json" endpoint returns a 500 error because of an invalid parameter being used in a function (an attempt to remove the MongoDB object ID from the endpoint).
Solution: remove the object ID directly in the aggregate query.
Added a simple test to verify that the endpoint is at least working a little bit.