Fix: storage API bugs #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: when a user uploads a file with the /storage and /ipfs add_file/add_json endpoints, the corresponding files are not downloadable until a corresponding STORE message is processed. This is problematic if the message is not sent to the same node or if the message fails to be processed because of a bug. The file would then be impossible to download, making the message unprocessable for other nodes. Solution: add an entry in the `files` table for each uploaded file.
Problem: POST /ipfs/add_file returns a 500 in all cases. Solution: fix the URI, a typo was introduced that made the IPFS daemon URI look like /api/v0/api/v0/<endpoint> instead of just /api/v0/<endpoint>.
Problem: we create the aiohttp app in a separate coroutine, which results in an "event loop is closed" error when using some functions of the IPFS client. Solution: do not initialize the app ourselves and let web.run_app() do it by passing the create_app() coroutine as argument.
odesenfans
force-pushed
the
od-fix-storage-api-bugs
branch
4 times, most recently
from
487bf35 to
cdb16b0
Compare
Problem: we use the cumulative size in /ipfs/add_file and when processing STORE messages for files above 1MB. Solution: use the cumulative size for directories and use the size field for everything else.
odesenfans
force-pushed
the
od-fix-storage-api-bugs
branch
from
cdb16b0 to
016d5cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four fixes: