Skip to content

Fix: ignore trusted messages for on-chain sync #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix: ignore trusted messages for on-chain sync #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/aleph/db/accessors/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def get_unconfirmed_messages(
)

select_stmt = select(MessageDb).where(
~select_message_confirmations.exists()
MessageDb.signature.isnot(None) & (~select_message_confirmations.exists())
)

return (session.execute(select_stmt.limit(limit))).scalars()
Expand Down
12 changes: 12 additions & 0 deletions tests/db/test_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,18 @@ async def test_get_unconfirmed_messages(
assert unconfirmed_messages == []


@pytest.mark.asyncio
async def test_get_unconfirmed_messages_trusted_messages(session_factory:DbSessionFactory, fixture_message: MessageDb):
fixture_message.signature = None
with session_factory() as session:
session.add(fixture_message)
session.commit()

with session_factory() as session:
unconfirmed_messages = list(get_unconfirmed_messages(session))
assert unconfirmed_messages == []


@pytest.mark.asyncio
async def test_get_distinct_channels(
session_factory: DbSessionFactory, fixture_message: MessageDb
Expand Down