Fix: filtering by tags #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-reactivate-filtering-by-tags
branch
2 times, most recently
from
44b2d28 to
933e0ec
Compare
odesenfans
changed the title
Problems: * the `tags` filter in /messages.json is not additive and filters out messages that don't match all the specified tags, instead of returning messages that have at least one matching tag. * filtering posts by tags filters out all results. Solution: fix the SQL queries, the filter was comparing the specified tags against the post tags as strings instead of checking for inclusion. We now use the '?|' operator to check if the message/post tags match at least one of the specified tags.
odesenfans
force-pushed
the
od-reactivate-filtering-by-tags
branch
from
933e0ec to
4607d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
tagsfilter in /messages.json is not additive and filters outmessages that don't match all the specified tags, instead of returning
messages that have at least one matching tag.
Solution: fix the SQL queries, the filter was comparing the specified
tags against the post tags as strings instead of checking for
inclusion. We now use the '?|' operator to check if the message/post
tags match at least one of the specified tags.