Fix: filter amended posts by ref on /api/v0/posts.json #417
+187
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: amended posts do not appear when filtering the results of `/api/v0/posts.json` with the `refs` query parameter. Solution: do not take the `ref` of the amend into account as it will always be equal to the `item_hash` of the original post.
odesenfans
force-pushed
the
od-fix-filtering-posts-by-ref
branch
from
83f841c to
53f11ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: amended posts do not appear when filtering the results of
/api/v0/posts.jsonwith therefsquery parameter.Solution: do not take the
refof the amend into account as it will always be equal to theitem_hashof the original post.