Fix: websocket issues #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
odesenfans
commented
May 1, 2023
odesenfans
commented
- Avoid acknowledgement issues in message WS
- Properly terminate requests to the message WS.
Problem: when a large number of websockets are open simultaneously, at some point a message acknowledgement is not performed and the channel/connection gets closed by the RabbitMQ broker. Solution: use the WS in no_ack mode, we do not benefit from acknowledgements in this use case anyway.
Problem: Websocket requests to api/ws0/messages never terminate, resulting in resources leaking (ex: RabbitMQ queues). Solution: split the implementation in two tasks: * the main task reads the websocket and expects a `close` message. * the secondary task publishes messages from the RabbitMQ queue to the websocket. Once a close event is detected, the main task cancels the secondary task and deletes the queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.