Fix: avoid channel closed exception in message websocket #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-fix-ws-timeout-exception
branch
4 times, most recently
from
eb21158 to
664e75d
Compare
Problem: upon closing, the message websocket may attempt to close the RabbitMQ channel. This appears to be caused by the handling of `CancellationError` in the `close()` method of the queue iterator. Solution: replace the `iterator` implementation with a simpler `consume` + callback implementation. This guarantees that the secondary task will never attempt to close the channel. Replace task cancellation by a call to `queue.cancel()` as aiormq handles cancellation exceptions by closing the channel.
odesenfans
force-pushed
the
od-fix-ws-timeout-exception
branch
from
664e75d to
753be84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: upon closing, the message websocket may attempt to close the RabbitMQ channel. This appears to be caused by the handling of
CancellationErrorin theclose()method of the queue iterator.Solution: replace the
iteratorimplementation with a simplerconsume+ callback implementation. This guarantees that the secondary task will never attempt to close the channel. Replace task cancellation by a call toqueue.cancel()as aiormq handles cancellation exceptions by closing the channel.