Skip to content

Commit 48c5088

Browse files
committed
fix(typescript): add peerDependency on typescript
Set it to 3.0 or greater. This lets us drop some e2e testing which was taking a long time on CI. Also add e2e testing for TS 3.6 which was just released. Note that typescript doesn't do semver so it's possible that something breaks before 4.0. If users report that, we'll have to re-publish with a narrowed range.
1 parent 2c947e2 commit 48c5088

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

e2e/BUILD.bazel

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,13 @@ e2e_integration_test(
134134
},
135135
workspace_files = "@e2e_typescript//:all_files",
136136
) for tsc_version in [
137-
"2.7.x",
138-
"2.8.x",
139-
"2.9.x",
140137
"3.0.x",
141138
"3.1.x",
142139
"3.2.x",
143140
"3.3.x",
144141
"3.4.x",
145142
"3.5.x",
143+
"3.6.x",
146144
]]
147145

148146
e2e_integration_test(

packages/typescript/src/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
"ts_auto_deps": "./ts_auto_deps/ts_auto_deps.js",
2222
"tsc_wrapped": "./internal/tsc_wrapped/tsc_wrapped.js"
2323
},
24+
"//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us",
25+
"peerDependencies": {
26+
"typescript": ">=3.0.0 <4.0"
27+
},
2428
"dependencies": {
2529
"protobufjs": "6.8.8",
2630
"semver": "5.6.0",

0 commit comments

Comments
 (0)