Skip to content

Conversation

@alexrudall
Copy link
Owner

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

@alexrudall alexrudall merged commit 6d0ab6c into main Oct 15, 2024
7 checks passed
Comment on lines +1096 to +1097
# Create assistant
assistant_id = client.assistants.create(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for documenting this and providing an example, that's really helpful!

If I could only make a change here that would be somehow communicating the fact that creating an assistant should be a one-time action, a user won't need to recreate the assistant for every attempt to describe or read an image, that's what threads are for

Copy link
Owner Author

@alexrudall alexrudall Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I treat them as pretty throwaway as well :D

What about # Create assistant (or grab an existing one)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true, they come for free, I like to keep them unique for organization purposes anyway

To be honest I treat them as pretty throwaway as well :D

What about # Create assistant (or grab an existing one)

That sounds good, there is always room for clarifying more but that's probably out of scope of your example here

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, I tweaked it a bit more here

Thanks for the suggestion!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for taking it into consideration! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants