fixed: Use correct type for serializatoin/deserialization of ignorePlurals

Currently, ignorePlurals, which could be either a boolean or a list of
languages (as strings) is serialized to boolean or comma-separated
string of languages, which is incorrect.

This commit now correctly serialize ignorePlurals as either a boolean or
an array of strings, and conversely when deserializing.

Author: aseure

algoliasearch-common/src/main/java/com/algolia/search/objects/IgnorePlurals.java

@@ -4,8 +4,6 @@
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonDeserializer;
 import com.fasterxml.jackson.databind.JsonSerializer;
@@ -14,7 +12,6 @@
 import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 import java.io.IOException;
 import java.io.Serializable;
-import java.util.Arrays;
 import java.util.List;
 
 @JsonDeserialize(using = IgnorePluralsDeserializer.class)
@@ -92,11 +89,11 @@ public String toString() {
 class IgnorePluralsDeserializer extends JsonDeserializer<IgnorePlurals> {
 
   @Override
-  public IgnorePlurals deserialize(JsonParser p, DeserializationContext ctxt)
-      throws IOException, JsonProcessingException {
-    JsonToken currentToken = p.getCurrentToken();
-    if (currentToken.equals(JsonToken.VALUE_STRING)) {
-      return IgnorePlurals.of(Arrays.asList(p.getValueAsString().split(",")));
+  public IgnorePlurals deserialize(JsonParser p, DeserializationContext ctxt) throws IOException {
+
+    if (p.isExpectedStartArrayToken()) {
+      List languages = p.readValueAs(List.class);
+      return IgnorePlurals.of(languages);
     }
 
     return IgnorePlurals.of(p.getBooleanValue());
@@ -108,12 +105,16 @@ class IgnorePluralsSerializer extends JsonSerializer<IgnorePlurals> {
   @SuppressWarnings("unchecked")
   @Override
   public void serialize(IgnorePlurals value, JsonGenerator gen, SerializerProvider serializers)
-      throws IOException, JsonProcessingException {
+      throws IOException {
     if (value instanceof IgnorePluralsBoolean) {
       gen.writeBoolean((Boolean) value.getInsideValue());
     } else if (value instanceof IgnorePluralsListString) {
-      List<String> list = (List<String>) value.getInsideValue();
-      gen.writeString(String.join(",", list));
+      List<String> languages = (List<String>) value.getInsideValue();
+      gen.writeStartArray();
+      for (String lang : languages) {
+        gen.writeString(lang);
+      }
+      gen.writeEndArray();
     }
   }
 }

algoliasearch-tests/src/test/java/com/algolia/search/JacksonParserTest.java

@@ -119,11 +119,11 @@ public void serializeIgnorePlurals() throws IOException {
     settings =
         new IndexSettings().setIgnorePlurals(IgnorePlurals.of(Collections.singletonList("en")));
     assertThat(DEFAULT_OBJECT_MAPPER.writeValueAsString(settings))
-        .isEqualTo("{\"ignorePlurals\":\"en\"}");
+        .isEqualTo("{\"ignorePlurals\":[\"en\"]}");
 
     settings = new IndexSettings().setIgnorePlurals(Arrays.asList("en", "fr"));
     assertThat(DEFAULT_OBJECT_MAPPER.writeValueAsString(settings))
-        .isEqualTo("{\"ignorePlurals\":\"en,fr\"}");
+        .isEqualTo("{\"ignorePlurals\":[\"en\",\"fr\"]}");
   }
 
   @Test
@@ -138,13 +138,13 @@ public void deserializeIgnorePlurals() throws IOException {
 
     ignorePlurals =
         DEFAULT_OBJECT_MAPPER
-            .readValue("{\"ignorePlurals\":\"en\"}", IndexSettings.class)
+            .readValue("{\"ignorePlurals\":[\"en\"]}", IndexSettings.class)
             .getIgnorePlurals();
     assertThat(ignorePlurals).isEqualTo(IgnorePlurals.of(Collections.singletonList("en")));
 
     ignorePlurals =
         DEFAULT_OBJECT_MAPPER
-            .readValue("{\"ignorePlurals\":\"en,fr\"}", IndexSettings.class)
+            .readValue("{\"ignorePlurals\":[\"en\",\"fr\"]}", IndexSettings.class)
             .getIgnorePlurals();
     assertThat(ignorePlurals).isEqualTo(IgnorePlurals.of(Arrays.asList("en", "fr")));
   }