Remove es6-promise dependency

[gajus]

algoliasearch-client-javascript/package.json

Line 63 in a751362

"es6-promise": "^4.0.5",

It is not your (as a library) responsibility to polyfill browser features. If you must use promises, document the requirement and require that the consumer of the library polyfills the feature.

[gajus]

As a workaround, a webpack consumer can define an alias that resolves to an empty module, e.g. {alias: {'es6-promise': 'empty-module'}} (and install empty-module module).

[vvo]

@gajus You are totally right. When we built the new version of the JavaScript client, not a single environement was supporting Promises by default.

But we still wanted to push that API to consumers without having them to Polyfill Promises that we knew would be available at some point.

We have many ideas on how to again do a modern-pass on the JavaScript client and will keep you updated when this is done.

[daniel-nagy]

Came here to say the same thing. Ending up with two promise libraries in my application bundle.

Edit
If you're using Webpack and you are already bundling your own promise polyfill that patches the global namespace then you can safely ignore the version being required by algoliasearch.

new webpack.IgnorePlugin(new RegExp('es6-promise'))

[lukeed]

I'd love to see the "engines.node": ">= 0.8" being addressed as well. That was marked stable back in 2012-2013. And Node 0.10.x moved out of LTS and into "End of Life" status in 2016. I can't even find when 0.8.x was terminated.

This may be the most-used and most all-encompassing lib I've found 😆So much room/opportunity to slim down this awesome sdk

[Haroenv]

Don't worry, we are currently working on making a brand new version, which of course won't support node 0.8. We've historically been very careful with breaking support for older engines in this library, and therefore didn't have the major version chance of changing support.

This is going to change once that is completely rethought (there's a lot of assumptions in this library that need to be considered), but until then the best option is to indeed just alias it for an empty module.

[nunomaduro]

This v4.0 is in progress, and we took into consideration all those points.