Skip to content

Browse: Ensure cursor is passed in the body #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Browse: Ensure cursor is passed in the body #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion algoliasearch/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,11 @@ def browse_from(self, params=None, cursor=None, request_options=None):
params = {}
if cursor:
params = {'cursor': cursor}
return self._req(True, '/browse', 'GET', request_options, params)

if not params:
return self._req(True, '/browse', 'GET', request_options, params)
else:
return self._req(True, '/browse', 'POST', request_options, None, params)

def browse_all(self, params=None, request_options=None):
"""
Expand Down
6 changes: 6 additions & 0 deletions tests/test_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,12 @@ def test_browse_all(ro_index):
assert set(ro_index.ids) == set(res_ids)


def test_browse_from(ro_index):
tmp = ro_index.browse(0, 4)
it = ro_index.browse_from(cursor=tmp['cursor'])
assert len(it['hits']) == 1


def test_search(ro_index):
res = ro_index.search('')
assert res['nbHits'] == 5
Expand Down