chore(ci): make the cache not depends on generated files #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
Maybe rebase this PR on top of #451 so we know if it works directly? |
|
good idea ! |
millotp
force-pushed
the
chore/cache-no-gen-file
branch
from
84075cf to
8b9b4f1
Compare
millotp
force-pushed
the
chore/cache-no-gen-file
branch
from
8b9b4f1 to
52f6850
Compare
|
I can already smell victory here |
|
purrfect |
millotp
force-pushed
the
chore/cache-no-gen-file
branch
from
3975e3b to
8351ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
This is an attempt to fix the CI on #451, the cache depends on generated files but the cache key are generated before the generation happens, thus in the Post Cache job the cache-key is incorrect.
Changes included:
🧪 Test
CI