feat(java): Add WithHTTPInfo method derivatives #5712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
MarioAlexandruDan
changed the title
shortcuts
reviewed
Dec 3, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
congrats on your first pr!!!!!!!!!!!!!!
...lgoliasearch-client-java/algoliasearch/src/main/java/com/algolia/internal/HttpRequester.java
Outdated
Show resolved
Hide resolved
…com/algolia/internal/HttpRequester.java Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Fluf22
reviewed
Dec 3, 2025
shortcuts
reviewed
Dec 3, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
nice, too bad we can't reuse the WithHTTPInfo methods in the non WithHTTPInfo ones, but looks clean!!
shortcuts
reviewed
Dec 3, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
can you remove the [API-135] from the PR title? We only put them in the body, but the title will be added to the changelog and customer don't need this kind of infos
MarioAlexandruDan
changed the title
shortcuts
approved these changes
Dec 3, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
perfect, congrats on your first PR merged!
algolia-bot
added a commit
that referenced
this pull request
Dec 3, 2025
…skip ci] Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Dec 3, 2025
algolia/api-clients-automation#5712 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
MarioAlexandruDan
added a commit
that referenced
this pull request
Dec 4, 2025
…rated) [skip ci]" This reverts commit bffff93.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mustache code generation for java
HttpRequester modification for WithHTTPInfo methods
🧭 What and Why
🎟 JIRA Ticket API-135:
https://algolia.atlassian.net/browse/API-135
Changes included:
🧪 Test