feat(csharp): Add WithHTTPInfo method derivatives #5715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
MarioAlexandruDan
force-pushed
the
feat/csharp-withhttpinfo-sufix
branch
from
e2cd0a9 to
5706781
Compare
MarioAlexandruDan
force-pushed
the
feat/csharp-withhttpinfo-sufix
branch
from
f3b5644 to
1e97906
Compare
Fluf22
approved these changes
Dec 4, 2025
Collaborator
Fluf22
left a comment
Fluf22
left a comment
There was a problem hiding this comment.
This looks great
It would be perfect if we could find a way to test it, next!
shortcuts
reviewed
Dec 4, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
Looks good at first glance, gg! but @morganleroi knows better
| {{#isDeprecated}} | ||
| [Obsolete] | ||
| {{/isDeprecated}} | ||
| public async Task<AlgoliaHttpResponse>{{operationId}}WithHTTPInfoAsync({{#allParams}}{{{dataType}}} {{paramName}}{{^required}}{{#optionalMethodArgument}} = default{{/optionalMethodArgument}}{{/required}}{{^-last}}, {{/-last}}{{/allParams}}{{#allParams.0}}, {{/allParams.0}}RequestOptions options = null, CancellationToken cancellationToken = default) |
Member
There was a problem hiding this comment.
I wonder if the async should be before the WithHTTPInfo or not
Contributor
Author
There was a problem hiding this comment.
I kept WithHTTPInfo before async in Java templates too
algolia-bot
added a commit
that referenced
this pull request
Dec 5, 2025
… [skip ci] Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Dec 5, 2025
algolia/api-clients-automation#5715 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Mario-Alexandru Dan <marioalexandrudan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
We should expose derivative of each operation with a WithHTTPInfo suffix that returns the raw HTTP response from the API so that can be evaluated when needed (status code access, for example)
🎟 JIRA Ticket API-136:
https://algolia.atlassian.net/browse/API-136?actionerId=62a8b1d6bf7afc006f3b6d9c&sourceType=assign
Changes included:
🧪 Test