feat(specs): add advanced personalization profile type #5720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
raed667
force-pushed
the
feat/spec/adv-perso/add-profile-type
branch
from
3b1bf07 to
ae594aa
Compare
bengreenbank
approved these changes
Dec 8, 2025
Collaborator
|
@raed667 okay to merge? |
raed667
commented
Dec 8, 2025
| example: 'session' | ||
|
|
||
| userType: | ||
| title: userType |
Contributor
Author
There was a problem hiding this comment.
maybe this should be
Suggested change
| title: userType | |
| title: type |
@Fluf22 what do you think ? i'm having doubts 😄
Member
There was a problem hiding this comment.
you might end up with restricted name conflicts in some language and weird random name from the generator 🥶
Collaborator
There was a problem hiding this comment.
You can push a commit and check the gen'd code to confirm, though
(or gen locally and see how it behaves)
Contributor
Author
There was a problem hiding this comment.
Thanks both 🙏
IMO the current setup is good and what we'd expect:
LGTM for merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Add
Advanced Personalizationprofile attributetype