Skip to content

Conversation

@yyyanghj
Copy link
Contributor

Close #535

The autocomplete container's parent element becomes offsetParent when there is a css declaration position:relative, where offsetTop is calculated relative to the parent element and not the actual position of the container in the page.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 17, 2021

@francoischalifour francoischalifour self-requested a review April 20, 2021 15:26
@francoischalifour francoischalifour changed the title fix: correct panel postion fix(js): compute panel top position with getBoundingClientRect Apr 22, 2021
Copy link
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yyyang1996! I updated the tests in 1e4e436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The position of the panel rendering is not calculated correctly

2 participants