fix(showMore): hide "show less" when nothing to hide

Author: vvo

src/components/RefinementList/RefinementList.js

@@ -130,8 +130,10 @@ class RefinementList extends React.Component {
     const limit = this.state.isShowMoreOpen ? this.props.limitMax : this.props.limitMin;
     let displayedFacetValues = this.props.facetValues.slice(0, limit);
     const displayShowMore = this.props.showMore === true &&
+      // "Show more"
       this.props.facetValues.length > displayedFacetValues.length ||
-      this.state.isShowMoreOpen === true;
+      // "Show less", but hide it if the result set changed
+      this.state.isShowMoreOpen && displayedFacetValues.length > this.props.limitMin;
 
     const showMoreBtn = displayShowMore ?
         <Template

src/components/RefinementList/__tests__/RefinementList-test.js

@@ -240,6 +240,28 @@ describe('RefinementList', () => {
       expect(actual.length).toEqual(0);
     });
 
+    it('no showMore when: state = open -> values change -> values <= limitMin ', () => {
+      // Given
+      let props = {
+        facetValues: [
+          {name: 'foo'},
+          {name: 'bar'},
+          {name: 'baz'}
+        ],
+        showMore: true,
+        limitMin: 2,
+        limitMax: 5
+      };
+
+      // When
+      let root = shallowRender(props);
+      root.instance().handleClickShowMore();
+      root.setProps({facetValues: props.facetValues.slice(2)});
+
+      // Then
+      expect(root.find({templateKey: 'show-more-active'}).length).toEqual(0);
+    });
+
     it('does not add a showMore link when the facet values length is equal to the minLimit', () => {
       // Given
       let props = {