Skip to content

Commit 7f32161

Browse files
samoussbobylito
authored andcommitted
fix: React reference: Breadcrumb & RangeInput components (#2618)
* fix(Breadcrumb): remove react reference * fix(RangeInput): remove react reference * fix(range-input-test): mock the correct import
1 parent fd15d55 commit 7f32161

File tree

5 files changed

+14
-12
lines changed

5 files changed

+14
-12
lines changed

src/components/Breadcrumb/Breadcrumb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { PureComponent } from 'react';
1+
import React, { PureComponent } from 'preact-compat';
22
import PropTypes from 'prop-types';
33
import Template from '../Template.js';
44
import autoHideContainerHOC from '../../decorators/autoHideContainer.js';

src/components/RangeInput/RangeInput.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { Component } from 'react';
1+
import React, { Component } from 'preact-compat';
22
import PropTypes from 'prop-types';
33
import autoHideContainerHOC from '../../decorators/autoHideContainer.js';
44
import headerFooterHOC from '../../decorators/headerFooter.js';

src/widgets/breadcrumb/breadcrumb.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import React from 'react';
2-
import ReactDOM from 'react-dom';
1+
import React, { render } from 'preact-compat';
32
import cx from 'classnames';
43

54
import Breadcrumb from '../../components/Breadcrumb/Breadcrumb';
@@ -38,7 +37,7 @@ const renderer = ({
3837

3938
const shouldAutoHideContainer = autoHideContainer && !canRefine;
4039

41-
ReactDOM.render(
40+
render(
4241
<Breadcrumb
4342
canRefine={canRefine}
4443
cssClasses={cssClasses}

src/widgets/range-input/__tests__/range-input-test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1-
import ReactDOM from 'react-dom';
1+
import ReactDOM from 'preact-compat';
22
import AlgoliasearchHelper from 'algoliasearch-helper';
33
import rangeInput from '../range-input.js';
44

5-
jest.mock('react-dom', () => ({
6-
render: jest.fn(),
7-
}));
5+
jest.mock('preact-compat', () => {
6+
const module = require.requireActual('preact-compat');
7+
8+
module.render = jest.fn();
9+
10+
return module;
11+
});
812

913
describe('rangeInput', () => {
1014
const attributeName = 'aNumAttr';

src/widgets/range-input/range-input.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import React from 'react';
2-
import ReactDOM from 'react-dom';
1+
import React, { render } from 'preact-compat';
32
import cx from 'classnames';
43
import RangeInput from '../../components/RangeInput/RangeInput.js';
54
import connectRange from '../../connectors/range/connectRange.js';
@@ -45,7 +44,7 @@ const renderer = ({
4544
max: maxValue !== Infinity && maxValue !== rangeMax ? maxValue : undefined,
4645
};
4746

48-
ReactDOM.render(
47+
render(
4948
<RangeInput
5049
min={rangeMin}
5150
max={rangeMax}

0 commit comments

Comments
 (0)