fix(ie): do not rely on Object.assign (#2885)

* docs(CONTRIBUTING): fix command for debugging func test app
* test(functional): use routing instead of urlSync
* fix(ie): do not rely on Object.assign
* chore(lint): fix lint
* refactor(functional-test): remove recorded search data

Author: bobylito

CONTRIBUTING.md

@@ -293,7 +293,7 @@ the test page with your VM. **Do not commit this change**
 ```
 
 Then you should be able debug using the dev setup: `yarn run dev` and the virtual machine. You can also
-run the page used for function tests using `yarn run test:functional:dev:debug`
+run the page used for function tests using `yarn run test:functional:dev:debug-server`
 
 ## Linting ✨
 

functional-tests/app/app.js

@@ -31,13 +31,13 @@ export default class RoutingManager {
       currentConfiguration.index,
       currentConfiguration
     ).state;
-    return Object.assign(
-      {},
-      this.getAllSearchParameters({
+    // The content of getAllSearchParameters is destructured to return a plain object
+    return {
+      ...this.getAllSearchParameters({
         currentSearchParameters: this.originalConfig,
         uiState: this.originalUIState,
-      })
-    );
+      }),
+    };
   }
 
   render({ state }) {
@@ -63,11 +63,10 @@ export default class RoutingManager {
         uiState,
       });
 
-      const fullHelperState = Object.assign(
-        {},
-        this.originalConfig,
-        searchParameters
-      );
+      const fullHelperState = {
+        ...this.originalConfig,
+        ...searchParameters,
+      };
 
       if (isEqual(fullHelperState, searchParameters)) return;
 
@@ -162,11 +161,10 @@ export default class RoutingManager {
         uiState,
       });
 
-      const fullSearchParameters = Object.assign(
-        {},
-        this.originalConfig,
-        searchParameters
-      );
+      const fullSearchParameters = {
+        ...this.originalConfig,
+        ...searchParameters,
+      };
 
       fn(fullSearchParameters);
     });

src/lib/RoutingManager.js

@@ -1,7 +1,6 @@
 import algoliasearchHelper from 'algoliasearch-helper';
 import urlHelper from 'algoliasearch-helper/src/url';
 import isEqual from 'lodash/isEqual';
-import assign from 'lodash/assign';
 
 const AlgoliaSearchHelper = algoliasearchHelper.AlgoliaSearchHelper;
 
@@ -162,7 +161,10 @@ class URLSync {
     clearTimeout(this.urlUpdateTimeout);
     // compare with helper.state
     const partialHelperState = helper.getState(this.trackedParameters);
-    const fullHelperState = assign({}, this.originalConfig, partialHelperState);
+    const fullHelperState = {
+      ...this.originalConfig,
+      ...partialHelperState,
+    };
 
     if (isEqual(fullHelperState, fullState)) return;
 
@@ -215,7 +217,10 @@ class URLSync {
         qs,
         { mapping: this.mapping }
       );
-      const fullState = assign({}, this.originalConfig, partialState);
+      const fullState = {
+        ...this.originalConfig,
+        ...partialState,
+      };
       fn(fullState);
     });
   }

src/lib/url-sync.js

@@ -131,14 +131,11 @@ function analytics({
 
     let formattedParams = [];
 
-    const serializedRefinements = serializeRefinements(
-      Object.assign(
-        {},
-        state.state.disjunctiveFacetsRefinements,
-        state.state.facetsRefinements,
-        state.state.hierarchicalFacetsRefinements
-      )
-    );
+    const serializedRefinements = serializeRefinements({
+      ...state.state.disjunctiveFacetsRefinements,
+      ...state.state.facetsRefinements,
+      ...state.state.hierarchicalFacetsRefinements,
+    });
 
     const serializedNumericRefinements = serializeNumericRefinements(
       state.state.numericRefinements