Skip to content

Commit c89f99d

Browse files
committed
fix(escapeHits): dont apply configuration if not requested
1 parent 9ed3353 commit c89f99d

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

src/connectors/hits/__tests__/connectHits-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe('connectHits', () => {
1313
// flag set accordingly
1414
const rendering = sinon.stub();
1515
const makeWidget = connectHits(rendering);
16-
const widget = makeWidget();
16+
const widget = makeWidget({escapeHits: true});
1717

1818
expect(widget.getConfiguration()).toEqual({
1919
highlightPreTag: '__ais-highlight__',
@@ -37,7 +37,7 @@ describe('connectHits', () => {
3737
expect(rendering.callCount).toBe(1);
3838
// test if isFirstRendering is true during init
3939
expect(rendering.lastCall.args[1]).toBe(true);
40-
expect(rendering.lastCall.args[0].widgetParams).toEqual({});
40+
expect(rendering.lastCall.args[0].widgetParams).toEqual({escapeHits: true});
4141

4242
widget.render({
4343
results: new SearchResults(helper.state, [{}]),
@@ -49,7 +49,7 @@ describe('connectHits', () => {
4949
// test that rendering has been called during init with isFirstRendering = false
5050
expect(rendering.callCount).toBe(2);
5151
expect(rendering.lastCall.args[1]).toBe(false);
52-
expect(rendering.lastCall.args[0].widgetParams).toEqual({});
52+
expect(rendering.lastCall.args[0].widgetParams).toEqual({escapeHits: true});
5353
});
5454

5555
it('Provides the hits and the whole results', () => {

src/connectors/hits/connectHits.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ export default function connectHits(renderFn) {
6060

6161
return (widgetParams = {}) => ({
6262
getConfiguration() {
63-
return tagConfig;
63+
return widgetParams.escapeHits
64+
? tagConfig
65+
: undefined;
6466
},
6567

6668
init({instantSearchInstance}) {

src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ describe('connectInfiniteHits', () => {
1414
const rendering = sinon.stub();
1515
const makeWidget = connectInfiniteHits(rendering);
1616
const widget = makeWidget({
17+
escapeHits: true,
1718
hitsPerPage: 10,
1819
});
1920

@@ -40,6 +41,7 @@ describe('connectInfiniteHits', () => {
4041
// test if isFirstRendering is true during init
4142
expect(rendering.lastCall.args[1]).toBe(true);
4243
expect(rendering.lastCall.args[0].widgetParams).toEqual({
44+
escapeHits: true,
4345
hitsPerPage: 10,
4446
});
4547

@@ -56,6 +58,7 @@ describe('connectInfiniteHits', () => {
5658
expect(rendering.callCount).toBe(2);
5759
expect(rendering.lastCall.args[1]).toBe(false);
5860
expect(rendering.lastCall.args[0].widgetParams).toEqual({
61+
escapeHits: true,
5962
hitsPerPage: 10,
6063
});
6164
});

src/connectors/infinite-hits/connectInfiniteHits.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ export default function connectInfiniteHits(renderFn) {
8282

8383
return {
8484
getConfiguration() {
85-
return tagConfig;
85+
return widgetParams.escapeHits
86+
? tagConfig
87+
: undefined;
8688
},
8789

8890
init({instantSearchInstance, helper}) {

src/widgets/infinite-hits/__tests__/infinite-hits-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe('infiniteHits()', () => {
3737
templates: defaultTemplates,
3838
useCustomCompileOptions: {item: false, empty: false},
3939
};
40-
widget = infiniteHits({container, cssClasses: {root: ['root', 'cx']}});
40+
widget = infiniteHits({container, escapeHits: true, cssClasses: {root: ['root', 'cx']}});
4141
widget.init({helper, instantSearchInstance: {}});
4242
results = {hits: [{first: 'hit', second: 'hit'}]};
4343
});

0 commit comments

Comments
 (0)