fix(numericMenu): prevent refinement reset on checked radio click (#3749)

Author: Yannick Croissant

src/components/RefinementList/RefinementList.js

@@ -99,6 +99,16 @@ class RefinementList extends Component {
       return;
     }
 
+    if (
+      isRefined &&
+      originalEvent.target.parentNode.querySelector(
+        'input[type="radio"]:checked'
+      )
+    ) {
+      // Prevent refinement for being reset if the user clicks on an already checked radio button
+      return;
+    }
+
     if (originalEvent.target.tagName === 'INPUT') {
       this.refine(facetValueToRefine, isRefined);
       return;

src/components/RefinementList/__tests__/RefinementList-test.js

@@ -426,5 +426,37 @@ describe('RefinementList', () => {
 
       expect(wrapper).toMatchSnapshot();
     });
+
+    it('should not refine on click on already refined items', () => {
+      const toggleRefinement = jest.fn();
+      const props = {
+        container: document.createElement('div'),
+        facetValues: [
+          { value: 'foo', isRefined: false },
+          { value: 'bar', isRefined: true },
+          { value: 'baz', isRefined: false },
+        ],
+        templateProps: {
+          templates: {
+            item: item => `
+              <label>
+                <input type="radio" checked=${item.isRefined} />
+                ${item.value}
+              </span>
+            `,
+          },
+        },
+        toggleRefinement,
+        createURL: () => {},
+      };
+      const wrapper = mount(<RefinementList {...props} />);
+
+      const items = wrapper.find(RefinementListItem);
+      const secondItem = items.at(1);
+
+      secondItem.simulate('click');
+
+      expect(toggleRefinement).not.toHaveBeenCalled();
+    });
   });
 });