Skip to content

Commit e997728

Browse files
francoischalifourHaroenv
francoischalifour
authored and
Haroenv
committed
feat(currentRefinements): support multiple indices (#4012)
1 parent b4b5454 commit e997728

File tree

13 files changed

+392
-133
lines changed

13 files changed

+392
-133
lines changed

‎src/components/CurrentRefinements/CurrentRefinements.tsx‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ const CurrentRefinements = ({ items, cssClasses }: CurrentRefinementsProps) => (
3737
<div className={cssClasses.root}>
3838
<ul className={cssClasses.list}>
3939
{items.map((item, index) => (
40-
<li key={`${item.attribute}-${index}`} className={cssClasses.item}>
40+
<li
41+
key={`${item.indexName}-${item.attribute}-${index}`}
42+
className={cssClasses.item}
43+
>
4144
<span className={cssClasses.label}>{capitalize(item.label)}:</span>
4245

4346
{item.refinements.map(refinement => (

‎src/components/CurrentRefinements/__tests__/CurrentRefinements-test.tsx‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe('CurrentRefinements', () => {
1919
cssClasses,
2020
items: [
2121
{
22+
indexName: 'indexName',
2223
attribute: 'facet',
2324
label: 'facet',
2425
refine: () => {},
@@ -38,6 +39,7 @@ describe('CurrentRefinements', () => {
3839
],
3940
},
4041
{
42+
indexName: 'indexName',
4143
attribute: 'facetExclude',
4244
label: 'facetExclude',
4345
refine: () => {},
@@ -52,6 +54,7 @@ describe('CurrentRefinements', () => {
5254
],
5355
},
5456
{
57+
indexName: 'indexName',
5558
attribute: 'disjunctive',
5659
label: 'disjunctive',
5760
refine: () => {},
@@ -65,6 +68,7 @@ describe('CurrentRefinements', () => {
6568
],
6669
},
6770
{
71+
indexName: 'indexName',
6872
attribute: 'hierarchical',
6973
label: 'hierarchical',
7074
refine: () => {},
@@ -78,6 +82,7 @@ describe('CurrentRefinements', () => {
7882
],
7983
},
8084
{
85+
indexName: 'indexName',
8186
attribute: 'numeric',
8287
label: 'numeric',
8388
refine: () => {},
@@ -92,6 +97,7 @@ describe('CurrentRefinements', () => {
9297
],
9398
},
9499
{
100+
indexName: 'indexName',
95101
attribute: 'tag',
96102
label: 'tag',
97103
refine: () => {},
@@ -118,6 +124,7 @@ describe('CurrentRefinements', () => {
118124
cssClasses,
119125
items: [
120126
{
127+
indexName: 'indexName',
121128
attribute: 'customFacet',
122129
label: 'customFacet',
123130
refine: () => {},
@@ -143,6 +150,7 @@ describe('CurrentRefinements', () => {
143150
cssClasses,
144151
items: [
145152
{
153+
indexName: 'indexName',
146154
attribute: 'customExcludeFacet',
147155
label: 'customExcludeFacet',
148156
refine: () => {},
@@ -169,6 +177,7 @@ describe('CurrentRefinements', () => {
169177
cssClasses,
170178
items: [
171179
{
180+
indexName: 'indexName',
172181
attribute: 'customDisjunctiveFacet',
173182
label: 'customDisjunctiveFacet',
174183
refine: () => {},
@@ -194,6 +203,7 @@ describe('CurrentRefinements', () => {
194203
cssClasses,
195204
items: [
196205
{
206+
indexName: 'indexName',
197207
attribute: 'customHierarchicalFacet',
198208
label: 'customHierarchicalFacet',
199209
refine: () => {},
@@ -219,6 +229,7 @@ describe('CurrentRefinements', () => {
219229
cssClasses,
220230
items: [
221231
{
232+
indexName: 'indexName',
222233
attribute: 'customNumericFilter',
223234
label: 'customNumericFilter',
224235
refine: () => {},
@@ -233,6 +244,7 @@ describe('CurrentRefinements', () => {
233244
],
234245
},
235246
{
247+
indexName: 'indexName',
236248
attribute: 'customNumericFilter',
237249
label: 'customNumericFilter',
238250
refine: () => {},
@@ -247,6 +259,7 @@ describe('CurrentRefinements', () => {
247259
],
248260
},
249261
{
262+
indexName: 'indexName',
250263
attribute: 'customNumericFilter',
251264
label: 'customNumericFilter',
252265
refine: () => {},
@@ -273,6 +286,7 @@ describe('CurrentRefinements', () => {
273286
cssClasses,
274287
items: [
275288
{
289+
indexName: 'indexName',
276290
attribute: '_tags',
277291
label: '_tags',
278292
refine: () => {},
@@ -298,6 +312,7 @@ describe('CurrentRefinements', () => {
298312
cssClasses,
299313
items: [
300314
{
315+
indexName: 'indexName',
301316
attribute: 'query',
302317
label: 'query',
303318
refine: () => {},

‎src/components/CurrentRefinements/__tests__/__snapshots__/CurrentRefinements-test.tsx.snap‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ exports[`CurrentRefinements options.refinements can be used with a disjunctive f
99
>
1010
<li
1111
className="item"
12-
key="customDisjunctiveFacet-0"
12+
key="indexName-customDisjunctiveFacet-0"
1313
>
1414
<span
1515
className="label"
@@ -47,7 +47,7 @@ exports[`CurrentRefinements options.refinements can be used with a facet 1`] = `
4747
>
4848
<li
4949
className="item"
50-
key="customFacet-0"
50+
key="indexName-customFacet-0"
5151
>
5252
<span
5353
className="label"
@@ -85,7 +85,7 @@ exports[`CurrentRefinements options.refinements can be used with a hierarchical
8585
>
8686
<li
8787
className="item"
88-
key="customHierarchicalFacet-0"
88+
key="indexName-customHierarchicalFacet-0"
8989
>
9090
<span
9191
className="label"
@@ -123,7 +123,7 @@ exports[`CurrentRefinements options.refinements can be used with a query 1`] = `
123123
>
124124
<li
125125
className="item"
126-
key="query-0"
126+
key="indexName-query-0"
127127
>
128128
<span
129129
className="label"
@@ -163,7 +163,7 @@ exports[`CurrentRefinements options.refinements can be used with a tag 1`] = `
163163
>
164164
<li
165165
className="item"
166-
key="_tags-0"
166+
key="indexName-_tags-0"
167167
>
168168
<span
169169
className="label"
@@ -201,7 +201,7 @@ exports[`CurrentRefinements options.refinements can be used with an exclude 1`]
201201
>
202202
<li
203203
className="item"
204-
key="customExcludeFacet-0"
204+
key="indexName-customExcludeFacet-0"
205205
>
206206
<span
207207
className="label"
@@ -239,7 +239,7 @@ exports[`CurrentRefinements options.refinements can be used with numeric filters
239239
>
240240
<li
241241
className="item"
242-
key="customNumericFilter-0"
242+
key="indexName-customNumericFilter-0"
243243
>
244244
<span
245245
className="label"
@@ -266,7 +266,7 @@ exports[`CurrentRefinements options.refinements can be used with numeric filters
266266
</li>
267267
<li
268268
className="item"
269-
key="customNumericFilter-1"
269+
key="indexName-customNumericFilter-1"
270270
>
271271
<span
272272
className="label"
@@ -293,7 +293,7 @@ exports[`CurrentRefinements options.refinements can be used with numeric filters
293293
</li>
294294
<li
295295
className="item"
296-
key="customNumericFilter-2"
296+
key="indexName-customNumericFilter-2"
297297
>
298298
<span
299299
className="label"
@@ -331,7 +331,7 @@ exports[`CurrentRefinements renders 1`] = `
331331
>
332332
<li
333333
className="item"
334-
key="facet-0"
334+
key="indexName-facet-0"
335335
>
336336
<span
337337
className="label"
@@ -374,7 +374,7 @@ exports[`CurrentRefinements renders 1`] = `
374374
</li>
375375
<li
376376
className="item"
377-
key="facetExclude-1"
377+
key="indexName-facetExclude-1"
378378
>
379379
<span
380380
className="label"
@@ -401,7 +401,7 @@ exports[`CurrentRefinements renders 1`] = `
401401
</li>
402402
<li
403403
className="item"
404-
key="disjunctive-2"
404+
key="indexName-disjunctive-2"
405405
>
406406
<span
407407
className="label"
@@ -428,7 +428,7 @@ exports[`CurrentRefinements renders 1`] = `
428428
</li>
429429
<li
430430
className="item"
431-
key="hierarchical-3"
431+
key="indexName-hierarchical-3"
432432
>
433433
<span
434434
className="label"
@@ -455,7 +455,7 @@ exports[`CurrentRefinements renders 1`] = `
455455
</li>
456456
<li
457457
className="item"
458-
key="numeric-4"
458+
key="indexName-numeric-4"
459459
>
460460
<span
461461
className="label"
@@ -482,7 +482,7 @@ exports[`CurrentRefinements renders 1`] = `
482482
</li>
483483
<li
484484
className="item"
485-
key="tag-5"
485+
key="indexName-tag-5"
486486
>
487487
<span
488488
className="label"

‎src/connectors/autocomplete/__tests__/connectAutocomplete-test.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ search.addWidgets([
166166
hits: firstIndexHits,
167167
}),
168168
]),
169+
helper,
169170
},
170171
{
171172
indexId: 'index1',
@@ -175,6 +176,7 @@ search.addWidgets([
175176
hits: secondIndexHits,
176177
}),
177178
]),
179+
helper,
178180
},
179181
];
180182

@@ -255,6 +257,7 @@ search.addWidgets([
255257
results: new SearchResults(helper.state, [
256258
createSingleSearchResponse({ hits }),
257259
]),
260+
helper,
258261
},
259262
],
260263
state: helper.state,
@@ -297,6 +300,7 @@ search.addWidgets([
297300
results: new SearchResults(helper.state, [
298301
createSingleSearchResponse({ hits }),
299302
]),
303+
helper,
300304
},
301305
],
302306
state: helper.state,

0 commit comments

Comments
 (0)