Skip to content

Commit ec7806c

Browse files
committed
feat(connectors): setValue() -> refine() / currentValue -> currentRefinement
1 parent 154cdb5 commit ec7806c

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

src/connectors/hits-per-page-selector/__tests__/connectHitsPerPageSelector-test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ describe('connectHitsPerPageSelector', () => {
8989
});
9090

9191
const firstRenderingOptions = rendering.lastCall.args[0];
92-
const {setValue} = firstRenderingOptions;
92+
const {refine} = firstRenderingOptions;
9393
expect(helper.getQueryParameter('hitsPerPage')).toBe(11);
94-
setValue(3);
94+
refine(3);
9595
expect(helper.getQueryParameter('hitsPerPage')).toBe(3);
9696

9797
widget.render({
@@ -102,7 +102,7 @@ describe('connectHitsPerPageSelector', () => {
102102
});
103103

104104
const secondRenderingOptions = rendering.lastCall.args[0];
105-
const {setValue: renderSetValue} = secondRenderingOptions;
105+
const {refine: renderSetValue} = secondRenderingOptions;
106106
expect(helper.getQueryParameter('hitsPerPage')).toBe(3);
107107
renderSetValue(10);
108108
expect(helper.getQueryParameter('hitsPerPage')).toBe(10);
@@ -134,8 +134,8 @@ describe('connectHitsPerPageSelector', () => {
134134
});
135135

136136
const firstRenderingOptions = rendering.lastCall.args[0];
137-
expect(firstRenderingOptions.currentValue).toBe(7);
138-
firstRenderingOptions.setValue(3);
137+
expect(firstRenderingOptions.currentRefinement).toBe(7);
138+
firstRenderingOptions.refine(3);
139139

140140
widget.render({
141141
results: new SearchResults(helper.state, [{}]),
@@ -145,7 +145,7 @@ describe('connectHitsPerPageSelector', () => {
145145
});
146146

147147
const secondRenderingOptions = rendering.lastCall.args[0];
148-
expect(secondRenderingOptions.currentValue).toBe(3);
148+
expect(secondRenderingOptions.currentRefinement).toBe(3);
149149
});
150150

151151
it('adds an option for the unselecting values, when the current hitsPerPage is defined elsewhere', () => {
@@ -172,7 +172,7 @@ describe('connectHitsPerPageSelector', () => {
172172

173173
const firstRenderingOptions = rendering.lastCall.args[0];
174174
expect(firstRenderingOptions.options.length).toBe(3);
175-
firstRenderingOptions.setValue(firstRenderingOptions.options[0].value);
175+
firstRenderingOptions.refine(firstRenderingOptions.options[0].value);
176176
expect(helper.getQueryParameter('hitsPerPage')).toBe(undefined);
177177

178178
// Reset the hitsPerPage to an actual value
@@ -187,7 +187,7 @@ describe('connectHitsPerPageSelector', () => {
187187

188188
const secondRenderingOptions = rendering.lastCall.args[0];
189189
expect(secondRenderingOptions.options.length).toBe(3);
190-
secondRenderingOptions.setValue(secondRenderingOptions.options[0].value);
190+
secondRenderingOptions.refine(secondRenderingOptions.options[0].value);
191191
expect(helper.getQueryParameter('hitsPerPage')).toBe(undefined);
192192
});
193193
});

src/connectors/hits-per-page-selector/connectHitsPerPageSelector.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ const usage = `Usage:
66
var customHitsPerPage = connectHitsPerPageSelector(function render(params, isFirstRendering) {
77
// params = {
88
// options,
9-
// currentValue,
10-
// setValue,
9+
// currentRefinement,
10+
// refine,
1111
// hasNoResults,
1212
// instantSearchInstance,
1313
// widgetParams,
@@ -29,8 +29,8 @@ Full documentation available at https://community.algolia.com/instantsearch.js/c
2929
* @property {Object[]} options Array of objects defining the different values and labels
3030
* @property {number} options[0].value number of hits to display per page
3131
* @property {string} options[0].label Label to display in the option
32-
* @property {number} currentValue the currently selected value of hitsPerPage
33-
* @property {function(number)} setValue sets the number of hits per page and trigger a search
32+
* @property {number} currentRefinement the currently selected value of hitsPerPage
33+
* @property {function(number)} refine sets the number of hits per page and trigger a search
3434
* @property {boolean} hasNoResults true if there were no results in the last search
3535
* @property {InstantSearch} instantSearchInstance the instance of instantsearch on which the widget is attached
3636
* @property {Object} widgetParams all original options forwarded to rendering
@@ -85,30 +85,30 @@ export default function connectHitsPerPageSelector(renderFn) {
8585
options = [{value: undefined, label: ''}].concat(options);
8686
}
8787

88-
const currentValue = state.hitsPerPage;
88+
const currentRefinement = state.hitsPerPage;
8989

9090
this.setHitsPerPage = value => helper
9191
.setQueryParameter('hitsPerPage', value)
9292
.search();
9393

9494
renderFn({
95-
currentValue,
95+
currentRefinement,
9696
options,
97-
setValue: this.setHitsPerPage,
97+
refine: this.setHitsPerPage,
9898
hasNoResults: true,
9999
widgetParams,
100100
instantSearchInstance,
101101
}, true);
102102
},
103103

104104
render({state, results, instantSearchInstance}) {
105-
const currentValue = state.hitsPerPage;
105+
const currentRefinement = state.hitsPerPage;
106106
const hasNoResults = results.nbHits === 0;
107107

108108
renderFn({
109-
currentValue,
109+
currentRefinement,
110110
options,
111-
setValue: this.setHitsPerPage,
111+
refine: this.setHitsPerPage,
112112
hasNoResults,
113113
widgetParams,
114114
instantSearchInstance,

src/widgets/hits-per-page-selector/hits-per-page-selector.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@ const renderer = ({
1717
cssClasses,
1818
autoHideContainer,
1919
}) => ({
20-
currentValue,
20+
currentRefinement,
2121
options,
22-
setValue,
22+
refine,
2323
hasNoResults,
2424
}, isFirstRendering) => {
2525
if (isFirstRendering) return;
2626

2727
ReactDOM.render(
2828
<Selector
2929
cssClasses={cssClasses}
30-
currentValue={currentValue}
30+
currentValue={currentRefinement}
3131
options={options}
32-
setValue={setValue}
32+
setValue={refine}
3333
shouldAutoHideContainer={autoHideContainer && hasNoResults}
3434
/>,
3535
containerNode

0 commit comments

Comments
 (0)