Skip to content

Commit f016326

Browse files
author
Eunjae Lee
authored
fix(types): fix cssClasses of voiceSearch (#3783)
* fix(types): fix cssClasses of voiceSearch * fix(types): handle the situation where type of cssClasses of voiceSearch changes * fix(types): change type of cssClasses of voiceSearch to fit in with the component
1 parent 7fa2a1b commit f016326

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

src/components/VoiceSearch/VoiceSearch.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
import React from 'preact-compat';
22
import Template from '../Template/Template';
33

4-
import {
5-
VoiceSearchCSSClasses,
6-
VoiceSearchTemplates,
7-
} from '../../widgets/voice-search/voice-search';
4+
import { VoiceSearchTemplates } from '../../widgets/voice-search/voice-search';
85

96
import {
107
VoiceListeningState,
118
ToggleListening,
129
} from '../../lib/voiceSearchHelper';
1310

11+
export type VoiceSearchComponentCSSClasses = {
12+
root: string;
13+
button: string;
14+
status: string;
15+
};
16+
1417
export type VoiceSearchProps = {
15-
cssClasses: VoiceSearchCSSClasses;
18+
cssClasses: VoiceSearchComponentCSSClasses;
1619
isBrowserSupported: boolean;
1720
isListening: boolean;
1821
toggleListening: ToggleListening;

src/widgets/voice-search/voice-search.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,19 @@ import { component } from '../../lib/suit';
88
import connectVoiceSearch, {
99
VoiceSearchRenderer,
1010
} from '../../connectors/voice-search/connectVoiceSearch';
11-
import VoiceSearch from '../../components/VoiceSearch/VoiceSearch';
11+
import VoiceSearch, {
12+
VoiceSearchComponentCSSClasses,
13+
} from '../../components/VoiceSearch/VoiceSearch';
1214
import defaultTemplates from './defaultTemplates';
1315
import { WidgetFactory, Template } from '../../types';
1416

1517
const withUsage = createDocumentationMessageGenerator({ name: 'voice-search' });
1618
const suit = component('VoiceSearch');
1719

1820
export type VoiceSearchCSSClasses = {
19-
root: string;
20-
button: string;
21-
status: string;
21+
root: string | string[];
22+
button: string | string[];
23+
status: string | string[];
2224
};
2325

2426
type VoiceSearchTemplateProps = {
@@ -44,7 +46,7 @@ type VoiceSearchWidgetParams = {
4446

4547
interface VoiceSearchRendererWidgetParams extends VoiceSearchWidgetParams {
4648
container: HTMLElement;
47-
cssClasses: VoiceSearchCSSClasses;
49+
cssClasses: VoiceSearchComponentCSSClasses;
4850
templates: VoiceSearchTemplates;
4951
}
5052

0 commit comments

Comments
 (0)