feat(rendering): Expose createElement#85
Merged
SophieManley03 merged 25 commits intonextfrom Jun 21, 2022
Merged
Conversation
sarahdayan
reviewed
Jun 9, 2022
SophieManley03
force-pushed
the
feat/recommend-templating-create-element
branch
2 times, most recently
from
3f8ded1 to
7022f3c
Compare
SophieManley03
force-pushed
the
feat/recommend-templating-create-element
branch
from
7022f3c to
bcfa781
Compare
sarahdayan
reviewed
Jun 13, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Member
|
@SophieManley03 For the two suggestions I made you'll need to add imports from |
Contributor
Author
|
Thank you Sarah, just did 👌 |
sarahdayan
reviewed
Jun 13, 2022
SophieManley03
force-pushed
the
feat/recommend-templating-create-element
branch
from
a5e1442 to
11cf12e
Compare
sarahdayan
reviewed
Jun 15, 2022
sarahdayan
approved these changes
Jun 20, 2022
Member
sarahdayan
left a comment
sarahdayan
left a comment
There was a problem hiding this comment.
Only nitpicks (feel free to apply or not), other than that it looks good to me. Great job!
…est.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes
createElementandFragmentfrom Preact.Summary
We want to remove the complexity of using JSX for our users using plain Javascript. In order to do that in a unify way accross our librairies, we are doing a similar work to the one done on Autocomplete.js.
This PR will be followed by another one that we allow HTML templating.