Skip to content
This repository was archived by the owner on May 27, 2019. It is now read-only.

Conversation

@Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 24, 2018

Nuxt and multi-index have really weird errors

@Haroenv Haroenv requested a review from rayrutjes January 24, 2018 19:00
Copy link
Member

@rayrutjes rayrutjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nuxt example is broken indeed. Cannot resolve "postcss-import" from "/Users/raymond/Code/vue-instantsearch-exa mples/examples/nuxt/postcss-import"

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 25, 2018

No idea why it’s broken though :(

@rayrutjes
Copy link
Member

It doesn't break on master, so it must be related to all the upgrades.

@rayrutjes
Copy link
Member

Feel free to take decisions though. Not sure what would be a better way to have a more maintainable examples repo.

@vvo
Copy link
Contributor

vvo commented Jan 26, 2018

Upgrading everything at once is hard but feasible. Let's ensure we setup renovate afterwards so that does not happen again (state where everything needs to be updated)

@vvo
Copy link
Contributor

vvo commented Jan 26, 2018

There should be a single yarn.lock at the root, a travis.yml file maybe, nvmrc, renovate.json, eslint .., example minimal setup for tooling etc can be seen at https://github.com/algolia/community-project-boilerplate/

let me know what you think

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 26, 2018

@vvo, that was exactly my plan, but stuck at this PR because I wasn't sure what caused the two regressions, and still trying to figure out how to get them back in a working state :)

@vvo
Copy link
Contributor

vvo commented Jan 26, 2018

and still trying to figure out how to get them back in a working state :)

Update one dep after the other and see when it breaks (I am sure that's what you are already doing, but stil)

@Haroenv Haroenv dismissed rayrutjes’s stale review February 6, 2018 16:40

nuxt was broken in a workspace, so worked around it

Copy link
Member

@rayrutjes rayrutjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works like this, go ahead 👍

@Haroenv Haroenv merged commit daac835 into master Feb 6, 2018
@Haroenv Haroenv deleted the chore/update-everything branch February 6, 2018 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants