Skip to content

Conversation

@aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Jan 30, 2025

  • Added extra deprecation for new_account staticmethod on SigningAccount (which was previously called Account in legacy v2 interfaces). Given that now algorand client provides access to manager that allows creation of accounts via random() im deprecating it too -> which should make it a further aligned with ts utils
  • Fixing broken link on readme pointing to self hosted docs, since jekyl was disabled to fix css the end url slightly changed
  • Fixing minor typo in update method call where compilation would be skipped, resulting in a response that lacks compiled and clear approvals
  • Addressing feedback that revealed a small bug in extra program pages calculation

@github-actions
Copy link

github-actions bot commented Jan 30, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py1411887%21, 40–42, 45, 54, 62, 81, 87, 96, 110–114, 133, 141–143
   account.py330%1–12
   algorand.py981585%62–63, 74–75, 95–96, 108–110, 119–120, 214, 234, 247, 263
   application_client.py330%1–11
   application_specification.py770%1–39
   config.py891880%26–28, 41, 53, 84–85, 100, 105, 110, 118–123, 153, 155, 157
   deploy.py330%1–10
   logic_error.py330%1–10
src/algokit_utils/_legacy_v2
   _ensure_funded.py71199%100
   _transfer.py70396%14, 75–76
   account.py931386%15–18, 70–74, 109, 126, 156, 159, 203
   application_client.py5367786%56–57, 175, 180, 209, 321, 326–327, 329, 331, 800, 815, 833–836, 930, 970, 982, 995, 1037, 1097–1103, 1107–1112, 1114, 1150, 1157, 1270, 1306, 1320, 1358–1360, 1362, 1372–1429, 1440–1445, 1465–1468
   asset.py80495%24–27
   common.py13192%13
   deploy.py4072295%32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 593–594, 618
   network_clients.py73593%77–78, 101–102, 135
src/algokit_utils/accounts
   account_manager.py2133385%162, 181–182, 206–211, 229–230, 247, 264–269, 316–318, 347, 386, 406–410, 423, 482, 503, 660, 766, 845, 850, 869–870, 893
   kmd_account_manager.py72889%49–53, 94, 150, 157
src/algokit_utils/applications
   abi.py1307145%14, 74, 110, 116, 118, 120, 124–125, 140–159, 175, 178–184, 200–213, 226–238, 253–264
   app_client.py72021171%65–73, 131, 139, 401–404, 407, 410, 413, 416, 428–431, 434, 437, 440, 443, 455, 464, 473, 476–543, 556–614, 638–640, 657–660, 668–671, 679–682, 690–693, 701–704, 715–718, 731, 827–830, 864, 876, 888, 900, 912, 927, 942, 952, 962, 972, 982, 992, 1029–1042, 1058, 1075, 1092, 1109, 1130, 1151, 1241, 1386, 1433–1434, 1465, 1467, 1473, 1518–1526, 1559–1562, 1565–1568, 1589, 1637, 1711–1718, 1759, 1776, 1778, 1781, 1785, 1912, 1923–1924, 1947, 1957–1959, 1962–1984, 1994, 2003–2018, 2023–2028
   app_deployer.py2094081%97, 195, 202, 212–217, 220–224, 262–276, 291–292, 481–494, 504, 509, 515, 521–523, 530, 544, 555–596
   app_factory.py2692790%357, 367, 370, 514, 522, 534, 683, 697–702, 708–709, 727, 752, 763–764, 800, 808–822
   app_manager.py2181693%226, 285–286, 318–323, 349, 367–368, 398, 419–422, 445, 454
src/algokit_utils/applications/app_spec
   arc32.py95892%198–207
   arc56.py4703692%72–74, 183, 318, 336–337, 415, 437–439, 495, 504, 506, 574, 769, 779, 783, 943, 945, 978–989, 1002, 1004–1005, 1021
src/algokit_utils/assets
   asset_manager.py1061289%266–267, 276, 282–306, 316
src/algokit_utils/clients
   client_manager.py1765469%24–26, 74–81, 95, 127–129, 185, 196–199, 224, 263, 298–303, 338–340, 370, 388, 407, 441–444, 477–480, 514–517, 547–550, 568–593, 623, 632, 640
   dispenser_api_client.py831286%126–127, 131–134, 169–171, 190–192
src/algokit_utils/errors
   logic_error.py561180%14, 105–121
src/algokit_utils/models
   account.py881484%31, 33, 79–80, 127, 135, 159–166, 180–181, 189, 197
   amount.py1071586%119, 129, 135, 143, 148–150, 157, 162–164, 171, 178, 191, 197
   application.py42198%8
   state.py36586%51, 55–58
   transaction.py51394%66, 86, 91
src/algokit_utils/protocols
   account.py11282%17, 22
   typed_clients.py24483%12–24
src/algokit_utils/transactions
   transaction_composer.py95113086%34–41, 619, 622, 627, 631–642, 674, 715, 782, 789, 811, 844, 907–970, 999, 1017–1019, 1025–1040, 1045, 1053, 1055, 1057, 1073, 1079, 1114–1121, 1124–1131, 1142, 1236, 1285, 1533–1534, 1573–1574, 1613, 1664–1668, 1824, 1827, 1846, 1851, 1875–1877, 1914–1950, 1957–1964, 2105, 2108, 2233, 2235–2236, 2286–2287
   transaction_creator.py75791%116, 121, 126, 131, 136, 141, 156
   transaction_sender.py1481093%88, 243, 286–287, 431–436, 441–442, 487
TOTAL626692685% 

Tests Skipped Failures Errors Time
396 0 💤 0 ❌ 0 🔥 4m 8s ⏱️

@aorumbayev aorumbayev changed the title docs: deprecate new_account from legacy v2 interface; fix link in readme fix: addressing feedback and minor tweaks Jan 30, 2025
@aorumbayev aorumbayev merged commit 007bb8e into main Jan 31, 2025
4 checks passed
@aorumbayev aorumbayev deleted the chore/minor-tweaks branch January 31, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants