Skip to content

fix: feedback batch #4 (uncovered as part of migrating testing, cli and subsciber repos) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: feedback batch #4 (uncovered as part of migrating testing, cli and subsciber repos) #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de4a875
fix: remove setting global handler that affects non algokit loggers
aorumbayev Feb 10, 2025
3b83392
chore: remove beaker
aorumbayev Feb 10, 2025
f443f36
fix: set token to empty string for mainnet and testnet
aorumbayev Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/markdown/autoapi/algokit_utils/applications/abi/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Wraps the raw return value and decoded value along with any decode errors.
* **value** – The decoded return value from the method call
* **method** – The ABI method definition
* **decode_error** – The exception that occurred during decoding, if any
* **tx_info** – The transaction info for the method call from raw algosdk ABIResult

#### raw_value *: bytes | None* *= None*

Expand All @@ -58,6 +59,8 @@ Wraps the raw return value and decoded value along with any decode errors.

#### decode_error *: Exception | None* *= None*

#### tx_info *: dict[str, Any] | None* *= None*

#### *property* is_success *: bool*

Returns True if the ABI call was successful (no decode error)
Expand Down
379 changes: 378 additions & 1 deletion legacy_v2_tests/app_client_test.json
View file
Open in desktop

Large diffs are not rendered by default.

199 changes: 0 additions & 199 deletions legacy_v2_tests/app_client_test.py
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions legacy_v2_tests/app_multi_underscore_template_var.py
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions legacy_v2_tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
get_kmd_client_from_algod_client,
replace_template_variables,
)
from legacy_v2_tests import app_client_test

if TYPE_CHECKING:
from algosdk.kmd import KMDClient
Expand Down Expand Up @@ -156,9 +155,6 @@ def funded_account(algod_client: "AlgodClient") -> Account:

@pytest.fixture(scope="session")
def app_spec() -> ApplicationSpecification:
app_spec = app_client_test.app.build()
path = Path(__file__).parent / "app_client_test.json"
path.write_text(app_spec.to_json())
return read_spec("app_client_test.json", deletable=True, updatable=True, template_values={"VERSION": 1})


Expand Down
Loading
Loading