[client] Introduce AdminApiDriver for workflows which lookup broker first then send request. #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
requested review from
leonardBang,
luoyuxia,
swuferhong and
wuchong
and removed request for
wuchong
loserwang1024
force-pushed
the
AdminApiDriver
branch
from
6f1b1d2 to
e0b1951
Compare
Contributor
Author
Contributor
|
@loserwang1024 The branch has conflicts. |
swuferhong
reviewed
Mar 5, 2025
fluss-client/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiFuture.java
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/exception/LeaderNotAvailableException.java
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiDriver.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiDriver.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiDriver.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiDriver.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/alibaba/fluss/client/admin/internal/AdminApiLookupBrokerIdStrategy.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/alibaba/fluss/client/admin/internal/BucketLeaderLeaderBrokerIdStrategy.java
Outdated
Show resolved
Hide resolved
loserwang1024
force-pushed
the
AdminApiDriver
branch
2 times, most recently
from
52a2c01 to
fd550fe
Compare
… first then send request.
loserwang1024
force-pushed
the
AdminApiDriver
branch
from
fd550fe to
439987e
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #288
Inspired by https://issues.apache.org/jira/browse/KAFKA-12609, which introduce AdminApiDriver do theses things:
Retry lookup stage on receiving
NOT_LEADER_OR_FOLLOWERandLEADER_NOT_AVAILABLE, whereas in the past we failed the partition directly without retry.retry fulfillment stage on
RetriableExceptionTests
API and Format
Some internal interface:
Documentation