fix: make rating aggregation updates atomic #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SELECT FOR UPDATE to lock GeneratedRoadmap row during counter updates - Prevents race condition where concurrent rating submissions corrupt counters - Fixes issue where rating_count could be 1 when 2 ratings were actually submitted - Ensures accurate rating averages in UI Without row locking, two users submitting ratings simultaneously could both read the same initial counters (e.g., 0) and each write back their own incremented values. The last commit would win, causing the first rating to be lost from the aggregated stats even though both roadmap_ratings rows were successfully inserted. All 8 rating tests passing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without row locking, two users submitting ratings simultaneously could both read the same initial counters (e.g., 0) and each write back their own incremented values. The last commit would win, causing the first rating to be lost from the aggregated stats even though both roadmap_ratings rows were successfully inserted.
All 8 rating tests passing.