Testing/cython #13
Closed
Testing/cython #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austoscaling_group* - Fix sanity errors SUMMARY Fix sanity errors - No need to backport to stable-6 or stable-5 because the back ported PRs include this fix already (ansible-collections#1598). ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…#1605) Update main branch after release 6.1.0 and 6.0.1 SUMMARY Update main branch after release 6.1.0 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Helen Bailey <hebailey@redhat.com>
Backup plan params bugfix
SUMMARY
This updates the backup_plan module to remove all None values from nested dicts in supplied params. Previously nested None values were retained and caused errors when sent through to the boto3 client calls.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
backup_plan
ADDITIONAL INFORMATION
Creating or updating a plan without providing an optional value in a nested dict would result in that value being set to None, and it wasn't being removed. For example:
- name: Update Backup plan
amazon.aws.backup_plan:
backup_plan_name: my-backup-plan
rules:
- rule_name: my-rule
target_backup_vault_name: my-vault
schedule_expression: "cron(0 * ? * * *)"
lifecycle:
move_to_cold_storage_after_days: 30
The optional lifecycle.delete_after_days option in the above example would be set to None by default, and the removal of None values wasn't recursively going through the entire dict. This is now fixed and the above example will work.
Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Bikouo Aubin
Refactor ARN validation code SUMMARY Adds resource_id and resource_type to parse_aws_arn() return value. Adds validate_aws_arn() to handle common pattern matching for ARNs. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance iam_user ADDITIONAL INFORMATION Related to ansible-collections/community.aws#1846 - We've been doing things like assuming the aws partition. Reviewed-by: Alina Buzachis
…ctions#1617) Fix typo in rds_instance docs for master_user_password SUMMARY Fix typo in rds_instance docs for master_user_password attribute ISSUE TYPE Docs Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
Backup vault tag bugfix SUMMARY Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_vault ADDITIONAL INFORMATION See the included new integration test task for a command that previously failed and works with the updated code. Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mike Graves <mgraves@redhat.com>
CI test fixups SUMMARY ansible/ansible milestone branch just got updated and introduced some breaking changes for us ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_security_group kms_key lambda ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Mike Graves <mgraves@redhat.com>
…nsible-collections#1615) Lambda execute stack trace should be not formatted with extra space SUMMARY Fixes ansible-collections#1497 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>
New modules: iam_instance_profile(_info) SUMMARY New modules for listing/managing IAM Instance Profiles ISSUE TYPE New Module Pull Request COMPONENT NAME iam_instance_profile iam_instance_profile_info ADDITIONAL INFORMATION Fixes: ansible-collections/community.aws#1842 Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
…-collections#1608) s3_object - allow recursive copy of all objects in S3 bucket SUMMARY Add support to copy recursively all objects from one bucket to another one, user can set prefix to limit the object to copy. closes ansible-collections#1379 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Bikouo Aubin
Add suggestion for isort config SUMMARY We've been slowly converging on a more consistent formatting on our imports, adds isort rule which implements this (doesn't force the change at this time unless someone explicitly runs isort) ISSUE TYPE Feature Pull Request COMPONENT NAME pyproject.toml ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <hebailey@redhat.com>
…-collections#1633) Document and validate backup_selection conditions suboptions SUMMARY Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes ansible-collections#1613 Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_selection module_utils.backup ADDITIONAL INFORMATION See ansible-collections#1613 for detailed description of related issue. Reviewed-by: Jill R Reviewed-by: Alina Buzachis
… to the rule (ansible-collections#1589) cloudwatchevent_rule should return false when there is no change done to the rule SUMMARY Fixes ansible-collections#1080 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/cloudwatchevent_rule.py ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell Reviewed-by: Jill R Reviewed-by: Alina Buzachis
…ivity_type=private (ansible-collections#1632) ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private SUMMARY Fixes ansible-collections#1618 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_vpc_nat_gateway.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…ons#1604) ec2_vpc_nat_gateway show fails if EIP doesn't exist SUMMARY Fixes ansible-collections#1295 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_vpc_nat_gateway ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>
…evel fix sanity - add devel and python3.9 from matrix exclude
…ctions#1577) ec2_instance_info - add support for include_attributes SUMMARY include_attributes allows the module to describe specific attributes for an EC2 instance ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance_info Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Helen Bailey <hebailey@redhat.com>
backup_selection - Documentation fix SUMMARY backup_selection - Documentation fix ISSUE TYPE Docs Pull Request COMPONENT NAME backup_selection Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mike Graves <mgraves@redhat.com>
Update changelog to reflect the 6.2.0 release SUMMARY Update changelog to reflect the 6.2.0 release ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mike Graves <mgraves@redhat.com>
…ing GlobalClusterIdentifier (ansible-collections#1663) Allow user to associate rds cluster with a global rds cluster SUMMARY Allow user to associate rds cluster with a global rds cluster ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (ansible-collections#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves <mgraves@redhat.com>
…b.com/ansible-network/github_actions/blob/main/.github/workflows/unit_source.yml Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
…up_units_workflow Update .github/workflows/units.yml
Default filters to empty dictionary SUMMARY Changes the default for the filters option from None to an empty dictionary. Fixes: ansible-collections#1668 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table_info ADDITIONAL INFORMATION This matches what other *info modules (e.g. ec2_vpc_endpoint_info or ec2_vpc_subnet_info) do for the filters option default. Reviewed-by: Alina Buzachis Reviewed-by: Brant Evans <bevans@redhat.com> Reviewed-by: Mark Chappell Reviewed-by: Mike Graves <mgraves@redhat.com>
…ctions#1631) route53_health_check - add support for CALCULATED type SUMMARY Fixes ansible-collections#1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Taeho Park Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>
…#1647) Added started and stopped states for rds cluster SUMMARY Fixes ansible-collections#1616 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>
…ions#1683) route53: add wait_id return value in case of changes SUMMARY This allows to wait for changes later on when wait=false is provided to the module. Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :) (I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.) ISSUE TYPE Feature Pull Request COMPONENT NAME route53 Reviewed-by: Mark Chappell
Fix misspelling in ec2_instance docs SUMMARY Fixes a misspelling in the docs, "Wether" -> "Whether" ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_instance Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
…nsible-collections#1688) Update CHANGELOG after 6.3.0 release SUMMARY Update CHANGELOG after 6.3.0 release ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
ssm_parameter: update examples to use FQCN SUMMARY This PR update examples to use FQCN. Fixes ansible-collections#1581 Should get reflected in module documentation on next doc generation. ISSUE TYPE Docs Pull Request COMPONENT NAME amazon.aws.ssm_parameter ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…e when a valid tag is pushed (ansible-collections#1696) SUMMARY Automatically generate the GitHub release when we push a valid tag. (Because we keep forgetting) ISSUE TYPE Feature Pull Request COMPONENT NAME .github/ ADDITIONAL INFORMATION
Update changelog to add 5.5.x entries SUMMARY Following 5.5.1, 5.5.2 and 5.5.3, we need to pull the changelog entries forwards into the main branch. ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/changelog.yaml ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Add various missing changelogs SUMMARY In the early days weren't consistent about keeping all changelogs in main. Add missing changelogs to main (from original branches) ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/changelog.yml ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <felix@fontein.de>
GHA: Exclude Python 3.9 runs for milestone branch SUMMARY At least for sanity tests. Ref: ansible-collections/news-for-maintainers#56 ISSUE TYPE Test Pull Request COMPONENT NAME GHA sanity tests Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.