cmkid,crc64,sign-v2 #160
Merged
cmkid,crc64,sign-v2 #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
彧贤 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
baiyubin
reviewed
Dec 13, 2018
| if (request.getExpiration() == null) { | ||
| throw new IllegalArgumentException(OSS_RESOURCE_MANAGER.getString("MustSetExpiration")); | ||
| } | ||
| String url; |
| /** | ||
| * Gets the user agent string. | ||
| * | ||
| * |
Contributor
There was a problem hiding this comment.
- ClientConfiguration.java中包括其它地方，代码格式化作为单独的提交，不要和功能修改混在一起；
| * bucket name and object key, and some constraint information can be set. | ||
| * @return The {@link ObjectMetadata} instance. | ||
| */ | ||
| public ObjectMetadata headObject(HeadObjectRequest headObjectRequest) throws OSSException, ClientException; |
| * @throws ClientException | ||
| * OSS Client side exception. | ||
| */ | ||
| public OSSObject getVodPlaylist(String bucketName, String liveChannelName, long startTime, |
Contributor
There was a problem hiding this comment.
- OSSObject getVodPlaylist中long startTime long endTime为什么不是Date
| return sb.toString(); | ||
| } | ||
|
|
||
| private static TreeSet<String> buildSortedAdditionalHeaderNames(Set<String> headerNames, Set<String> additionalHeaderNames) { |
Contributor
There was a problem hiding this comment.
- buildSortedAdditionalHeaderNames 的返回值 Set<String> 即可。
| * @param signatureVersion | ||
| * the signature version to switch to。 | ||
| */ | ||
| public void switchSignatureVersion(String signatureVersion); |
Contributor
There was a problem hiding this comment.
- switchSignatureVersion的参数枚举类型为最好，防止用户填错。
| public class SignTest { | ||
|
|
||
| @Test | ||
| public void testSignV2() { |
Contributor
There was a problem hiding this comment.
- V2的测试强度不够，每个API都需要在V2下跑一次。
| } | ||
|
|
||
| @Test | ||
| public void testGenerateSignedV2URL() { |
Contributor
There was a problem hiding this comment.
- 这个测试不足，用户指定headers，paramters的情况，callback的情况，以及getObject(URL signedUrl, Map<String, String> requestHeaders)/PutObjectResult putObject(URL signedUrl, String filePath, Map<String, String> requestHeaders)的应用等等。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support user-assigned cmk id header & get vod playlist & sign-v2 & head object api & download\upload crc64