Version => 0.3.5

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Change Log
 
+### v0.3.5
+
+- Fix the issue that StreamWriter will read more bytes than wanted
+
 ### v0.3.4
 
 - Fix handling gzip/deflate response

lib/aliyun/oss/http.rb

@@ -52,8 +52,13 @@ def read(bytes = nil, outbuf = nil)
           ret = ""
           loop do
             if bytes
-              ret << @buffer.slice!(0, bytes)
-              break if ret.size >= bytes
+              fail if bytes < 0
+              piece = @buffer.slice!(0, bytes)
+              if piece
+                ret << piece
+                bytes -= piece.size
+                break if bytes == 0
+              end
             else
               ret << @buffer
               @buffer.clear

lib/aliyun/version.rb

@@ -2,6 +2,6 @@
 
 module Aliyun
 
-    VERSION = "0.3.4"
+    VERSION = "0.3.5"
 
 end # Aliyun

spec/aliyun/oss/http_spec.rb

@@ -58,6 +58,24 @@ module OSS
           r = s.read
           expect(r).to eq('')
         end
+
+        it "should read exactly bytes" do
+          s = HTTP::StreamWriter.new do |sr|
+            100.times { sr << 'x' * 10 }
+          end
+
+          r = s.read(11)
+          expect(r.size).to eq(11)
+
+          r = s.read(25)
+          expect(r.size).to eq(25)
+
+          r = s.read(900)
+          expect(r.size).to eq(900)
+
+          r = s.read(1000)
+          expect(r.size).to eq(64)
+        end
       end # StreamWriter
 
     end # HTTP