made changes

[Illusion0-0]

this change is more better than the original code(it is simple ,easy and basic code for binary search in c++)

[abranhe]

Hi, @TARUNYO thanks for opening a pull request making changes to the Binary Search implementation.

In the pull request, you made you are using

#include <conio.h>

which is specific to the Windows console environment. This library limits you to work in a common Unix machine. Also the style used is very poor.

I personally implemented this algorithm

so I think you should review once to be be merged. You can open a new pull request requesting new changed because this one will be closed.

[Illusion0-0]

Hello Abraham nice that you read the changes carefully,but i'm sorry for #include<conio.h>.....i can't do anything with this as i am a learner of C++and jst beginning with C,so i knew this much as i corrected.

…

On Fri, Oct 5, 2018 at 1:45 AM Abraham Hernandez ***@***.***> wrote: Hi, @TARUNYO <https://github.com/Tarunyo> thanks for opening a pull request making changes to the Binary Search implementation. In the pull request, you made you are using #include <conio.h> which is specific to the Windows console environment. This library limits you to work in a common Unix machine. Also the style used is very *poor*. I personally implemented this algorithm so I think you should review once to be be merged. You can open a new pull request requesting new changed because this one will be closed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AfUu64_Ig8vcEIgMcQWYF5wjcCAL3JkSks5uhmx1gaJpZM4XDs4E> .

[Illusion0-0]

Btw from where you're Abraham? I am form INDIA.! You - ? May we be friends..!!?

…

On Sat, Oct 6, 2018 at 7:52 PM CODE STIEN ***@***.***> wrote: Hello Abraham nice that you read the changes carefully,but i'm sorry for #include<conio.h>.....i can't do anything with this as i am a learner of C++and jst beginning with C,so i knew this much as i corrected. On Fri, Oct 5, 2018 at 1:45 AM Abraham Hernandez ***@***.***> wrote: > Hi, @TARUNYO <https://github.com/Tarunyo> thanks for opening a pull > request making changes to the Binary Search implementation. > > In the pull request, you made you are using > > #include <conio.h> > > which is specific to the Windows console environment. This library limits > you to work in a common Unix machine. Also the style used is very *poor*. > I personally implemented this algorithm > > so I think you should review once to be be merged. You can open a new > pull request requesting new changed because this one will be closed. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#43 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AfUu64_Ig8vcEIgMcQWYF5wjcCAL3JkSks5uhmx1gaJpZM4XDs4E> > . >