Skip to content

Allow the submenu success message to be configurable #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2016
Merged

Allow the submenu success message to be configurable #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b3b4e5
Allow the submenu success message to be configurable
danielbachhuber Oct 2, 2014
cdfbcda
Merge branch 'master' into submenu-success
mboynes Jan 4, 2016
7ae57e8
Add unit test and clean up for merge
mboynes Jan 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion php/context/class-fieldmanager-context-submenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ class Fieldmanager_Context_Submenu extends Fieldmanager_Context_Storable {
*/
public $submit_button_label = Null;

/**
* The "success" message displayed after options are saved. Defaults to
* "Options updated".
*
* @var string|null
*/
public $updated_message = null;

/**
* @var string
* For submenu pages, set autoload to true or false
Expand All @@ -67,6 +75,7 @@ public function __construct( $parent_slug, $page_title, $menu_title = Null, $cap
$this->parent_slug = $parent_slug;
$this->page_title = $page_title;
$this->capability = $capability;
$this->updated_message = __( 'Options updated', 'fieldmanager' );
$this->uniqid = $this->fm->get_element_id() . '_form';
if ( ! $already_registered ) {
add_action( 'admin_menu', array( $this, 'register_submenu_page' ) );
Expand All @@ -91,7 +100,7 @@ public function render_submenu_page() {
?>
<div class="wrap">
<?php if ( ! empty( $_GET['msg'] ) && 'success' == $_GET['msg'] ) : ?>
<div class="updated success"><p><?php esc_html_e( 'Options updated', 'fieldmanager' ); ?></p></div>
<div class="updated success"><p><?php echo esc_html( $this->updated_message ); ?></p></div>
<?php endif ?>

<h1><?php echo esc_html( $this->page_title ) ?></h1>
Expand Down
11 changes: 11 additions & 0 deletions tests/php/test-fieldmanager-context-submenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,15 @@ public function presave_alter_number( $values, $context ) {
return $values;
}

public function test_updated_message() {
$name = 'message_customization';
$updated_message = rand_str();
fm_register_submenu_page( $name, 'tools.php', 'Message Customization' );
$context = $this->get_context( $name );
$context->updated_message = $updated_message;
$html = $this->get_html( $context, $name );
$this->build_post( $html, $name );
$this->assertContains( "<div class=\"updated success\"><p>{$updated_message}</p></div>", $this->get_html( $context, $name ) );
}

}