-
Notifications
You must be signed in to change notification settings - Fork 98
Restore AJAX data source for Chosen #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`use_ajax` is intended for taxonomies with lots of terms, where loading all at once would cause performance issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't seem to apply, but there should be an option to group by taxonomy.
|
I'm going to dive into this later this afternoon; I want to give it some more thought. Thanks for the PR! |
|
Not done quite yet — still plugging things back together. |
|
Ah OK. Thanks, let me know when it's ready for testing and review. |
|
@mboynes @netaustin I'd be interested in your initial thoughts on this. The UX needs more work, but I think this is a better approach than #251. @mboynes Let me know what tests you're thinking of. |
|
Bump @mboynes |
|
@danielbachhuber Sorry for the delay, I'm finally getting around to this. This looks great. I ran into some styling issues and while fixing them took the opportunity to update chosen to 1.3.0. I put that in #275 (as a PR to merge into this one). Re:what to test, that's a good question. I think we should be able to test 95% of it without having to fake an ajax request, since the ajax responder uses |
|
🏈 not worth pursuing this. Select2 is the way to go. |
In doing so, we can avoid the performance issues with large taxonomies
See #244