Skip to content

Conversation

@danielbachhuber
Copy link
Contributor

In doing so, we can avoid the performance issues with large taxonomies

See #244

`use_ajax` is intended for taxonomies with lots of terms, where loading
all at once would cause performance issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem to apply, but there should be an option to group by taxonomy.

@mboynes
Copy link
Contributor

mboynes commented Nov 7, 2014

I'm going to dive into this later this afternoon; I want to give it some more thought. Thanks for the PR!

@danielbachhuber
Copy link
Contributor Author

Not done quite yet — still plugging things back together.

@mboynes
Copy link
Contributor

mboynes commented Nov 7, 2014

Ah OK. Thanks, let me know when it's ready for testing and review.

@danielbachhuber
Copy link
Contributor Author

@mboynes @netaustin I'd be interested in your initial thoughts on this. The UX needs more work, but I think this is a better approach than #251.

@mboynes Let me know what tests you're thinking of.

@danielbachhuber
Copy link
Contributor Author

Bump @mboynes

@mboynes mboynes mentioned this pull request Dec 21, 2014
@mboynes
Copy link
Contributor

mboynes commented Dec 21, 2014

@danielbachhuber Sorry for the delay, I'm finally getting around to this. This looks great. I ran into some styling issues and while fixing them took the opportunity to update chosen to 1.3.0. I put that in #275 (as a PR to merge into this one).

Re:what to test, that's a good question. I think we should be able to test 95% of it without having to fake an ajax request, since the ajax responder uses Fieldmanager_Datasource::get_items_for_ajax() for the heavy lifting. Worth mentioning that I just wrote a bunch of tests in #274, so perhaps we should merge that before starting on tests for this one. I'd like to get that merged within the next day or two, and then I'd like to get this PR merged this week.

@mboynes mboynes added this to the 1.0 Beta milestone Dec 23, 2014
@mboynes mboynes modified the milestones: 1.0.0 Beta 3, 1.0.0 RC 1 Dec 31, 2015
@danielbachhuber
Copy link
Contributor Author

🏈 not worth pursuing this. Select2 is the way to go.

@danielbachhuber danielbachhuber removed this from the 1.0.0 RC milestone Feb 20, 2016
@renatonascalves renatonascalves deleted the 244-chosen-ajax branch February 21, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants