Skip to content

Conversation

@sc0ttkclark
Copy link

Includes hook docs! :)

@sc0ttkclark
Copy link
Author

Let's get this into 1.0.0 before it's too late :)

@danielbachhuber
Copy link
Contributor

Let's get this into 1.0.0 before it's too late

What are you trying to use it for? Can you share more details on your use case?

@sc0ttkclark
Copy link
Author

I was hoping to utilize this in additional contexts not yet supported, although it started out as me not fully understanding submenus covered settings pages. I thought this might be a useful hook in the future to help aide in integration with custom REST API endpoints (to tell FM what the context is, since it may not detect it).

@bcampeau
Copy link
Member

There's already a branch for REST API integration that adds a custom context function. That will supersede this.

Submenus pages are already covered too. I think we should likely close this.

@sc0ttkclark
Copy link
Author

Not including a filter like this would not promote integration testing in the future, just saying.

@mboynes
Copy link
Contributor

mboynes commented Feb 24, 2016

I like the idea in general, but it's too easy to inadvertently break things using this filter. I'm going to sleep on it and look at the code tomorrow; I think there's another place we could do this that would be safer.

@sc0ttkclark
Copy link
Author

What if we run it only if calculated context is empty?

@dlh01
Copy link
Member

dlh01 commented Aug 22, 2016

It looks to me like this was added in #510.

@mboynes
Copy link
Contributor

mboynes commented Dec 21, 2016

Closing, as this was added in #510 as david noted.

@mboynes mboynes closed this Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants