Cast scalar meta values as string #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces #617
dlh01
approved these changes
Oct 10, 2017
Member
dlh01
left a comment
dlh01
left a comment
There was a problem hiding this comment.
The similar logic seems to suggest a shared method on Fieldmanager_Context_Storable might be useful, like sanitize_scalar_value(). Up to you, though.
| protected function update_data( $post_id, $meta_key, $meta_value, $data_prev_value = '' ) { | ||
| // Meta is always stored as a string, so if this is a scalar value, cast | ||
| // it as a string to ensure that `update_metadata()` is able to correctly | ||
| // compare the current value against the previous value. |
Member
There was a problem hiding this comment.
Perhaps should follow docs standards for inline comments: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#5-2-multi-line-comments (applies throughout)?
| */ | ||
| protected function update_data( $data_id, $option_name, $option_value, $option_prev_value = '' ) { | ||
| // Meta is always stored as a string, so if this is a scalar value, cast | ||
| // it as a string to ensure that `update_metadata()` is able to correctly |
Member
There was a problem hiding this comment.
Should this be *_option() instead of _metadata, and the earlier reference to "Meta is" be "Options are"?
Contributor
Author
|
Thanks for the suggestion @dlh01. Not sure why I didn't consider that, it seems so obvious in retrospect. That also made it more testable, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #617, props @david-binda