Skip to content

Updates per latest phpcs standards #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2017
Merged

Updates per latest phpcs standards #669

merged 1 commit into from
Nov 5, 2017

Conversation

@mboynes
Copy link
Contributor

@mboynes mboynes commented Nov 4, 2017 •
edited
Loading

Also closes #492, as that method needed a phpcs update so I instead opted to use core's sanitize_hex_color().

jameswburke
jameswburke approved these changes Nov 4, 2017
View reviewed changes
Copy link
Contributor

@jameswburke jameswburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@mboynes mboynes merged commit 550f748 into master Nov 5, 2017
@renatonascalves renatonascalves deleted the phpcs-updates branch February 21, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jameswburke jameswburke jameswburke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use core's sanitize_hex_color() in Fieldmanager_Colorpicker

3 participants

@mboynes @jameswburke