Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 5, 2024

Description

This PR drastically rewrites the way Embeds are built, ctx or interaction are no longer passed. tux.bot.Tux is still passed due to latency fetching.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other: (write here)

Guidelines

  • My code follows the style guidelines of this project (formatted with Ruff)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation if needed

  • My changes generate no new warnings

  • I have tested this change

  • Any dependent changes have been merged and published in downstream modules

  • I have followed all of these guidelines.

Summary by Sourcery

Rewrite the EmbedCreator to streamline the embed creation process by removing the need to pass context or interaction objects. The new EmbedCreator class in tux.ui.embeds provides a unified interface for creating various types of embeds, which is now used across the codebase to enhance consistency and maintainability.

New Features:

  • Introduce a new EmbedCreator class in tux.ui.embeds to handle the creation of different types of embeds with a unified interface.

Enhancements:

  • Refactor the embed creation process across multiple modules to use the new EmbedCreator class, improving consistency and reducing code duplication.

@sourcery-ai

This comment was marked as duplicate.

sourcery-ai[bot]

This comment was marked as resolved.

@ghost ghost added the status: needs testing label Sep 5, 2024
@kzndotsh kzndotsh merged commit e2892e0 into main Sep 6, 2024
@kzndotsh kzndotsh deleted the tess-improve-embeds branch September 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant