Add type checking via mypy in CI #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confluent_kafka doesn't itself publish stubs, though there is https://pypi.org/project/confluent-kafka-stubs/. Unfortunately that project is limited to too recent a version of Python to use, see https://gitlab.com/theepic-dev/confluent-kafka-stubs/-/issues/1.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 98.29% 98.30%
=======================================
Files 34 35 +1
Lines 1352 1357 +5
=======================================
+ Hits 1329 1334 +5
Misses 23 23 ☔ View full report in Codecov by Sentry. |
alm0ra
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #113, suggest reviewing that first.
This gets the codebase to passing mypy checks, ready for perhaps making the mypy check blocking and/or publishing the type annotations (via
py.typedmarker file)