Message headers are lists of key-value pairs, not mappings #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be consistent between the Python clients, though confluent_kafka does allow passing headers in as a dict.
Collaborator
Author
|
Ah, just spotted that this duplicates #150, though appears to solve |
Owner
|
Let's close #150. It's been a long time, and I don't remember what I did. |
alm0ra
approved these changes
May 30, 2025
Owner
|
@PeterJCLaw There is a conflict here |
Owner
|
fix #149 |
Collaborator
Author
|
Note that I don't think this will address #149 fully -- that also reports issues with keys/values that are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be consistent between the Python clients, though confluent_kafka does allow passing headers in as a dict.
While I haven't tested it directly, some docs imply that Kafka may treat repeated keys as overwriting previous values, however looking at some of the bytestream parsing code it's not clear whether that actually happens or not.