Apply brand refresh to tech docs using show_govuk_logo
#415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romaricpascal
approved these changes
Jun 16, 2025
Member
romaricpascal
left a comment
romaricpascal
left a comment
There was a problem hiding this comment.
Looking grand, only comment is a little nitpick to make the tests a little more succint 😊
owenatgov
force-pushed
the
apply-brand-refresh
branch
from
8e962e8 to
1cfca9e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s changed
Applies the brand refresh introduced in GOV.UK Frontend 5.10.0 to tech docs when
show_govuk_logois set totrue. Ifshow_govuk_logois falsey, it will show the black header with blue bottom border.As part of this, this PR also:
show_govuk_logoCloses #411
Identifying a user need
Required for the GOV.UK brand refresh, happening across the GOV.UK estate on 25th June 2025.
Notes
There's a deeper discussion about what codebases using the tech docs gem but not the GOV.UK brand should look like, which we're not gonna solve with this PR. This brand updates project has identified a possible whiff around things that aren't GOV.UK-branded things co-opting bits of the GOV.UK brand eg: the black header and blue bar and where they fit into the GOV.UK ecosystem (should they even?). The Design System team are hoping to take a look at this eventually.
We should probably remove that extra test or incorperate it into the first test in the integration spec once govuk-frontend v6 is released and we remove the brand refresh feature flags.