-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "User Specified Date Feature" #2214
Revert "User Specified Date Feature" #2214
Conversation
This reverts commit 1ed595e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping main
green! Sorry you ran into trouble with conda. We can fix it 😁
@ParthivNaresh @dsherry What happened? |
@freddyaboulton Filed #2215 |
@ParthivNaresh Why did the "Date Feature" PR add pmdarima as a dependency if the Arima implementation still used statsmodels? I think that's what's causing the conda test failure. pmdarima is listed in our requirements.txt but not in conda recipe (I had suggested we keep pmdarima off the conda recipe since I thought it wasn't needed) |
@freddyaboulton We moved ARIMA from the |
Ah I read the diff wrong! The original date feature pr changed the underlying library used by Arima. Maybe what we should do then is add pmdarima to the conda recipe? Might need to remove |
Codecov Report
@@ Coverage Diff @@
## main #2214 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 296 296
Lines 24871 24712 -159
=========================================
- Hits 24853 24694 -159
Misses 18 18
Continue to review full report at Codecov.
|
@freddyaboulton If statsmodel isn’t required by anything else then I agree, we can take statsmodel out of the recipe. This might also fix the errors I was seeing when I added pmdarima to the recipe. There were a large number of dependency version mismatch issues which may have stemmed from its conflict with statsmodel. |
@ParthivNaresh Yea I don't think statsmodels is used by anything else. I think it's worth seeing if we can patch up the recipe before merging this pr? |
@freddyaboulton Sorry I didn’t see your message before merging (dang refreshing). But I’ll take a look at the recipe next for sure |
Fixes #2215
Reverts #2155
Reverting until we can figure out what's going on with
pmdarima
during installation