Skip to content

Correctly match boolean and null values #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alto merged 1 commit into from
Apr 28, 2014
Merged

Correctly match boolean and null values #3

alto merged 1 commit into from
Apr 28, 2014

Conversation

@pgaertig
Copy link
Contributor

@pgaertig pgaertig commented Apr 20, 2014

Here is the fix which correctly asserts with:

has "key", false
has "key", nil

Previously the above would pass a JSON with any value for the key.

@alto alto self-assigned this Apr 28, 2014
alto added a commit that referenced this pull request Apr 28, 2014
@alto
Merge pull request #3 from pgaertig/fix/boolean_values
48ade2e 
Correctly match boolean and null values
@alto alto merged commit 48ade2e into alto:master Apr 28, 2014
@alto
Copy link
Owner

alto commented Apr 28, 2014

Thank you 👍

@alto
Copy link
Owner

alto commented Apr 28, 2014

Released version 0.2.1 including your changes.

@pgaertig pgaertig deleted the fix/boolean_values branch April 28, 2014 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alto alto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgaertig @alto