Support separate OpenVR hand trackers for VRChat #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8704c99.
zmerp
force-pushed
the
vrc-hand-tracking
branch
2 times, most recently
from
5fff3c6
to
952922f
Compare
zmerp
changed the title
The-personified-devil
requested changes
Jul 28, 2024
zmerp
force-pushed
the
vrc-hand-tracking
branch
3 times, most recently
from
fa07dc5
to
8e9a30c
Compare
|
The PR should be ready now |
The-personified-devil
approved these changes
Jul 30, 2024
This was referenced Jul 31, 2024
zmerp
added a commit
that referenced
this pull request
Aug 15, 2024
* refactoring: around button register and openvr prop * feat: full skeletal level toggle button. * fix: incorrect import * chore: format * fix: incorrect typing * feat: VRSkeletalTrackingLevel Auto Switch * fix: renamed config item to match functionality * fix: code formatting * fix: support for independent skeletal tracking settings per-hand * Revert "refactoring: around button register and openvr prop" This reverts commit 8704c99. * feat: implement a full skeletal virtual hand * chore: format * Small refactor * Disable gestures by default and remove setup wizard page * Send button inputs to the active hand device * Don't update skeleton if device is disabled * Fix buttons not registered for hand trackers * Add Hand tracking interaction preset * Add comment for device switching * Edit help for use_separate_trackers --------- Co-authored-by: Reina_Sakiria <sasiki.64892@gmail.com> Co-authored-by: Adalyn Black <tomblackaz@gmail.com>
Merged
zmerp
added a commit
that referenced
this pull request
Aug 15, 2024
* refactoring: around button register and openvr prop * feat: full skeletal level toggle button. * fix: incorrect import * chore: format * fix: incorrect typing * feat: VRSkeletalTrackingLevel Auto Switch * fix: renamed config item to match functionality * fix: code formatting * fix: support for independent skeletal tracking settings per-hand * Revert "refactoring: around button register and openvr prop" This reverts commit 8704c99. * feat: implement a full skeletal virtual hand * chore: format * Small refactor * Disable gestures by default and remove setup wizard page * Send button inputs to the active hand device * Don't update skeleton if device is disabled * Fix buttons not registered for hand trackers * Add Hand tracking interaction preset * Add comment for device switching * Edit help for use_separate_trackers --------- Co-authored-by: Reina_Sakiria <sasiki.64892@gmail.com> Co-authored-by: Adalyn Black <tomblackaz@gmail.com>
zmerp
added a commit
that referenced
this pull request
Aug 15, 2024
* refactor(server): ♻️ Finish ServerCore split * feat(server): ✨ Split server into `_openvr` and `_core` * Wiki update from outdated information, refactor (#2233) * Update outdated wiki entries, small refactors allover wiki, reformats * Removed unnecessary change * PR review fixes, removed old audio script * Small change in separate networks on uix * docs: rename client to device * docs: update no device image * docs: don't update dev stuff * docs: remove oudated sidebar link --------- Co-authored-by: Leonhard Saam <leonhard.saam@yahoo.com> * chore: ⬆️ Update dependencies * chore: 🔧 Bump MSRV to 1.76 * docs: light refactor of linux troubleshooting page, add wlroots compositor mention (#2248) * client gfx refactor (9): init wgpu * client gfx refactor (10): wgpu lobby * docs: Put page title into file name * docs: Fix broken sidebar links * build(xtask): ⬆️ Update XR loaders (#2270) * wiki: Linux troubleshooting - VAAPI encoder error fix (#2247) * VAAPI encoder error fix * AMD users * feedback - add fedora to title * link to rpm docs * fix(client_openxr): 🐛 Fix stream; gl context was not made current (#2274) * fix(client): 🐛 Fix focus 3 crash (#2275) * fix(xtask): 🐛 Downgrade loader (#2276) * build(xtask): 🔨 Don't build all android targets by default (#2277) * fix: Change supported devices to all in manifest Fixes #2244 Fixes a bug where alvr couldn't use 120hz mode on quest 3 due to the system defaulting to reporting max 90hz if the quest 3 isn't listed as a supported device. * build(client_openxr): 🔨 Apply Meta store changes to manifest conditionally (#2281) * feat(streamer): ✨ Use more precision for brightness and constrast * build(client_openxr): 🔨 Require OpenGL ES 3.2 * build: ⬆️ Update dependencies * fix(server_core): 🐛 Fix tracking timing jitter (#2285) * Revert "build: ⬆️ Update dependencies" (#2286) This reverts commit 4f7aa2e. * wiki(linux): Fix Flatpak link; + troubleshooting (#2288) * ci: Add stale exclusion rule for PRs (#2289) * fix(dashboard): 🐛 Fix tooltips width (#2297) * Support separate OpenVR hand trackers for VRChat (#2295) * refactoring: around button register and openvr prop * feat: full skeletal level toggle button. * fix: incorrect import * chore: format * fix: incorrect typing * feat: VRSkeletalTrackingLevel Auto Switch * fix: renamed config item to match functionality * fix: code formatting * fix: support for independent skeletal tracking settings per-hand * Revert "refactoring: around button register and openvr prop" This reverts commit 8704c99. * feat: implement a full skeletal virtual hand * chore: format * Small refactor * Disable gestures by default and remove setup wizard page * Send button inputs to the active hand device * Don't update skeleton if device is disabled * Fix buttons not registered for hand trackers * Add Hand tracking interaction preset * Add comment for device switching * Edit help for use_separate_trackers --------- Co-authored-by: Reina_Sakiria <sasiki.64892@gmail.com> Co-authored-by: Adalyn Black <tomblackaz@gmail.com> * chore: Don't query audio devices on linux (#2303) * Prevent setting SharedTextureDesc to 0 when CreateTexture2D (#2309) * fix(dashboard): 💬 Fix "Software requirements" text on Linux (#2312) * fix(server): 🐛 Fix controllers tracking on VRChat (#2313) * refactor: 🚨 Fix some lints * client gfx refactor (11): wgpu stream * docs: 📝 Add release dates in CHANGELOG.md * fix: 🐛 Fix launcher crash; gui refactor (#2320) * fix(client_openxr): 🐛 Fix crash with vibration on Focus 3 (#2324) * fix(server_openvr): 🐛 Fix crash when disabling separate hand trackers (#2323) * Bump to 20.10.0 --------- Co-authored-by: Meister1593 <leruop@Gmail.com> Co-authored-by: Leonhard Saam <leonhard.saam@yahoo.com> Co-authored-by: Tom Nicklin <t-nicklin@hotmail.co.uk> Co-authored-by: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com> Co-authored-by: Reina_Sakiria <sasiki.64892@gmail.com> Co-authored-by: Adalyn Black <tomblackaz@gmail.com> Co-authored-by: szneqz <60541660+szneqz@users.noreply.github.com>
failboat78
pushed a commit
to failboat78/ALVR
that referenced
this pull request
Aug 17, 2024
* refactoring: around button register and openvr prop * feat: full skeletal level toggle button. * fix: incorrect import * chore: format * fix: incorrect typing * feat: VRSkeletalTrackingLevel Auto Switch * fix: renamed config item to match functionality * fix: code formatting * fix: support for independent skeletal tracking settings per-hand * Revert "refactoring: around button register and openvr prop" This reverts commit 8704c99. * feat: implement a full skeletal virtual hand * chore: format * Small refactor * Disable gestures by default and remove setup wizard page * Send button inputs to the active hand device * Don't update skeleton if device is disabled * Fix buttons not registered for hand trackers * Add Hand tracking interaction preset * Add comment for device switching * Edit help for use_separate_trackers --------- Co-authored-by: Reina_Sakiria <sasiki.64892@gmail.com> Co-authored-by: Adalyn Black <tomblackaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @ReinaS-64892 and @AdalynBlack
Closes #2290, #2283