periph: add a PeripheralInfo class for metadata.#19
Merged
whitequark merged 1 commit intoamaranth-lang:masterfrom Jul 16, 2020
Merged
periph: add a PeripheralInfo class for metadata.#19whitequark merged 1 commit intoamaranth-lang:masterfrom
whitequark merged 1 commit intoamaranth-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 7 +1
Lines 675 693 +18
Branches 142 145 +3
=========================================
+ Hits 675 693 +18
Continue to review full report at Codecov.
|
Member
|
I'll need some time to dig into this--please ping me on IRC in a week or two if I don't review this quickly enough. |
Member
Author
|
Updates, based on feedback from the July 6th IRC meeting:
|
whitequark
requested changes
Jul 16, 2020
Member
whitequark
left a comment
There was a problem hiding this comment.
Looks good other than the one comment.
whitequark
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #11 (comment).
This PR proposes a
PeripheralInfoclass to gather the resources of a peripheral, with the aim of advertising them to the BSP generator. AConfigDictclass is also provided to collect constants.